From patchwork Mon Jan 8 19:40:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 10150439 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6EC2760210 for ; Mon, 8 Jan 2018 19:40:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 67832288E0 for ; Mon, 8 Jan 2018 19:40:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 657BB2898C; Mon, 8 Jan 2018 19:40:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E22D728A69 for ; Mon, 8 Jan 2018 19:40:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756604AbeAHTkT (ORCPT ); Mon, 8 Jan 2018 14:40:19 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:50656 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756468AbeAHTkT (ORCPT ); Mon, 8 Jan 2018 14:40:19 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.21) with SMTP id w08Jaem8175051 for ; Mon, 8 Jan 2018 19:40:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : subject : message-id : mime-version : content-type; s=corp-2017-10-26; bh=Zr2511pAAwyQTUjHfzu6GD/KfDNcu0TU/Hh7IFq+ALw=; b=XvSlK7K3kVm2Nknoj0bYCqTVxFAnyFnwTMLyRMLLvFlWcUeApJlBtfvODc54/+TPyYf6 ZEmdO/iq+7DzEz7XyHn4/BdWEEoZQyRhpjQUOoXhISX9zwJVpnQBVAZZ0ZCcTBO7gRwe RLU4tYv6mz15B+ltSq3lRw/Lc7ukNZm1w1U6yN7wKu88SFGyzklxoF1NwQ25CVxT9XLY FKrCONgM62TpyWb5F2bTPn5mGCerMwP/8X1ZRwslOc18hSbn9Q6GoZ3UX2RTgLocLw1a DMS8P2pqupQ/GGpZ2/aWiQ10YFcMoNUv3SgV0E47AQP9NTFnnOPwm2JMjqJfaXDjmoDB cQ== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2120.oracle.com with ESMTP id 2fcesmg295-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 08 Jan 2018 19:40:18 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w08JeHh8032492 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 8 Jan 2018 19:40:17 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w08JeG9I019350 for ; Mon, 8 Jan 2018 19:40:16 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 08 Jan 2018 11:40:16 -0800 Date: Mon, 8 Jan 2018 11:40:15 -0800 From: "Darrick J. Wong" To: xfs Subject: [PATCH] xfs: clarify units in the failed metadata io message Message-ID: <20180108194015.GT5602@magnolia> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8768 signatures=668652 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1801080278 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Darrick J. Wong If a metadata IO error happens, we report the location of the failed IO request in units of daddrs. However, the printk message misleads people into thinking that the units are fs blocks, so fix the reported units. Signed-off-by: Darrick J. Wong --- fs/xfs/xfs_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index 1981ef7..582c64a 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -1196,7 +1196,7 @@ xfs_buf_ioerror_alert( const char *func) { xfs_alert(bp->b_target->bt_mount, -"metadata I/O error: block 0x%llx (\"%s\") error %d numblks %d", +"metadata I/O error: daddr 0x%llx (\"%s\") error %d numblks %d", (uint64_t)XFS_BUF_ADDR(bp), func, -bp->b_error, bp->b_length); }