diff mbox

xfs: fix non-debug build compiler warnings

Message ID 20180117164102.GE25805@magnolia (mailing list archive)
State Accepted
Headers show

Commit Message

Darrick J. Wong Jan. 17, 2018, 4:41 p.m. UTC 
From: Darrick J. Wong <djwong@djwong.org>

Fix compiler warning on non-debug build

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 fs/xfs/xfs_dquot_item.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Dave Chinner Jan. 18, 2018, 12:52 a.m. UTC | #1 
On Wed, Jan 17, 2018 at 08:41:02AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@djwong.org>
> 
> Fix compiler warning on non-debug build
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>  fs/xfs/xfs_dquot_item.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/fs/xfs/xfs_dquot_item.c b/fs/xfs/xfs_dquot_item.c
> index e564f11..51ee848 100644
> --- a/fs/xfs/xfs_dquot_item.c
> +++ b/fs/xfs/xfs_dquot_item.c
> @@ -150,10 +150,7 @@ xfs_dquot_item_error(
>  	struct xfs_log_item	*lip,
>  	struct xfs_buf		*bp)
>  {
> -	struct xfs_dquot	*dqp;
> -
> -	dqp = DQUOT_ITEM(lip)->qli_dquot;
> -	ASSERT(!completion_done(&dqp->q_flush));
> +	ASSERT(!completion_done(&DQUOT_ITEM(lip)->qli_dquot->q_flush));
>  	xfs_set_li_failed(lip, bp);

Looks fine.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
diff mbox

Patch

diff --git a/fs/xfs/xfs_dquot_item.c b/fs/xfs/xfs_dquot_item.c
index e564f11..51ee848 100644
--- a/fs/xfs/xfs_dquot_item.c
+++ b/fs/xfs/xfs_dquot_item.c
@@ -150,10 +150,7 @@  xfs_dquot_item_error(
 	struct xfs_log_item	*lip,
 	struct xfs_buf		*bp)
 {
-	struct xfs_dquot	*dqp;
-
-	dqp = DQUOT_ITEM(lip)->qli_dquot;
-	ASSERT(!completion_done(&dqp->q_flush));
+	ASSERT(!completion_done(&DQUOT_ITEM(lip)->qli_dquot->q_flush));
 	xfs_set_li_failed(lip, bp);
 }