From patchwork Thu Feb 1 00:47:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 10194963 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DCC6C60380 for ; Thu, 1 Feb 2018 00:47:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E8C88287B8 for ; Thu, 1 Feb 2018 00:47:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DBC82288BC; Thu, 1 Feb 2018 00:47:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6A29C287B8 for ; Thu, 1 Feb 2018 00:47:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932108AbeBAArt (ORCPT ); Wed, 31 Jan 2018 19:47:49 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:54968 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932104AbeBAArs (ORCPT ); Wed, 31 Jan 2018 19:47:48 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w110kr9s181256; Thu, 1 Feb 2018 00:47:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2017-10-26; bh=1tXmYSa6fLXwaMw/akikJkIiFwuo1Xwi4bOSFEzqdY0=; b=DP0L4ADo8zCrjLL4oF9UVD0D0tgmiV5Qye8TNbhNxPxVO+rrUuLiMOEoRr29OwIRUYeO S4ubuHSHZZlZLPUjAUKn4fAMpFBllAVEOfwIxDBMKXgz4+MJhsGnheq2lZQcYDgSfWzn /cyNVEQwMBKvcsEBygSAkQVz45HmENvgRDqsY73p2Nf8SRhR9iCxlDHm5J/29TOE+SdC UvhkCI6j9WhSxSD7Ihjx3DzYFERviZUDylNBceUScXQvHfdX6msOQMqsBmO5WV9pD/lB wlzl5Gr/nkPFnn5hUT8EErBjf1lhCL3ThmdGbY5PjJScX5UYY0Z1ncZpHClM3TLJqaYb pA== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp2130.oracle.com with ESMTP id 2fuqkfr60m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 01 Feb 2018 00:47:46 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w110lkA0024104 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 1 Feb 2018 00:47:46 GMT Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w110lk7p009762; Thu, 1 Feb 2018 00:47:46 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 31 Jan 2018 16:47:45 -0800 Date: Wed, 31 Jan 2018 16:47:45 -0800 From: "Darrick J. Wong" To: Eric Sandeen Cc: xfs Subject: [PATCH] mkfs: don't create realtime filesystems with reflink enabled Message-ID: <20180201004745.GL4849@magnolia> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8791 signatures=668659 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=703 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1802010009 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Darrick J. Wong We don't support reflink on the realtime device, so don't let people create such things. Signed-off-by: Darrick J. Wong Reviewed-by: Eric Sandeen --- mkfs/xfs_mkfs.c | 7 +++++++ 1 file changed, 7 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c index f527476..07774ed 100644 --- a/mkfs/xfs_mkfs.c +++ b/mkfs/xfs_mkfs.c @@ -2025,6 +2025,13 @@ _("cowextsize not supported without reflink support\n")); usage(); } + if (cli->sb_feat.reflink && cli->xi->rtname) { + fprintf(stderr, +_("reflink not supported with realtime devices\n")); + usage(); + cli->sb_feat.reflink = false; + } + if (cli->sb_feat.rmapbt && cli->xi->rtname) { fprintf(stderr, _("rmapbt not supported with realtime devices\n"));