diff mbox

[2/8] xfs: remove an outdated comment for xfs_inode_item_committing

Message ID 20180313104927.12926-3-hch@lst.de (mailing list archive)
State Accepted
Headers show

Commit Message

Christoph Hellwig March 13, 2018, 10:49 a.m. UTC
The function now does something, and that something is central to our
inode logging scheme.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/xfs/xfs_inode_item.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Darrick J. Wong March 13, 2018, 9:09 p.m. UTC | #1
On Tue, Mar 13, 2018 at 11:49:21AM +0100, Christoph Hellwig wrote:
> The function now does something, and that something is central to our
> inode logging scheme.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  fs/xfs/xfs_inode_item.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/xfs/xfs_inode_item.c b/fs/xfs/xfs_inode_item.c
> index b83fa38f1c74..31f2b32b7e27 100644
> --- a/fs/xfs/xfs_inode_item.c
> +++ b/fs/xfs/xfs_inode_item.c
> @@ -634,10 +634,6 @@ xfs_inode_item_committed(
>  	return lsn;
>  }
>  
> -/*
> - * XXX rcc - this one really has to do something.  Probably needs
> - * to stamp in a new field in the incore inode.
> - */
>  STATIC void
>  xfs_inode_item_committing(
>  	struct xfs_log_item	*lip,
> -- 
> 2.14.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/xfs/xfs_inode_item.c b/fs/xfs/xfs_inode_item.c
index b83fa38f1c74..31f2b32b7e27 100644
--- a/fs/xfs/xfs_inode_item.c
+++ b/fs/xfs/xfs_inode_item.c
@@ -634,10 +634,6 @@  xfs_inode_item_committed(
 	return lsn;
 }
 
-/*
- * XXX rcc - this one really has to do something.  Probably needs
- * to stamp in a new field in the incore inode.
- */
 STATIC void
 xfs_inode_item_committing(
 	struct xfs_log_item	*lip,