From patchwork Wed May 9 07:48:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 10388541 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8B547602C2 for ; Wed, 9 May 2018 07:50:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7AE5E28E56 for ; Wed, 9 May 2018 07:50:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6F42A28E68; Wed, 9 May 2018 07:50:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1076128E65 for ; Wed, 9 May 2018 07:50:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933953AbeEIHuc (ORCPT ); Wed, 9 May 2018 03:50:32 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:53590 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933889AbeEIHu2 (ORCPT ); Wed, 9 May 2018 03:50:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mkiQrVkgU3P38eG8wT5JelNiVMWL9IpaIco07dhQPyY=; b=R5e9yWLOqfSf0wf7Z5wBYY1KY DID8mzyT1BFkCnsbWA0KETFHCWCDTPtbbeRIviusihLlqHw/XYbegLWa+DmdTIiq+UwnekD48yFKP RB4NgEA2FlK6EnfhcFZXnw8FUs4HjO64YmHVUBek2lLv8o+G61Od9mZrkGHL5+VUmHwXLPoiKHbxO Kj/+zRRtkUoydlGHEF0wKTd+dE4kp8+QHBHSir3dCAJM0EFaM9078eqhm8gJN/gsNgZACqzGMMqIh MpA1+l8Yt/v+a+ddXb0iI3E1bEy728r0dZF7F3X7nzmfbffI+d4EOQXiOsGuOYfpnld0wRTu3jo1a J1ZZrRa6w==; Received: from 213-225-15-246.nat.highway.a1.net ([213.225.15.246] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fGJrn-0002vE-1A; Wed, 09 May 2018 07:50:27 +0000 From: Christoph Hellwig To: linux-xfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 29/33] xfs: do not set the page uptodate in xfs_writepage_map Date: Wed, 9 May 2018 09:48:26 +0200 Message-Id: <20180509074830.16196-30-hch@lst.de> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180509074830.16196-1-hch@lst.de> References: <20180509074830.16196-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We already track the page uptodate status based on the buffer uptodate status, which is updated whenever reading or zeroing blocks. This code has been there since commit a ptool commit in 2002, which claims to: "merge" the 2.4 fsx fix for block size < page size to 2.5. This needed major changes to actually fit. and isn't present in other writepage implementations. Signed-off-by: Christoph Hellwig --- fs/xfs/xfs_aops.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index dc82d4e71a64..dc92f23b0ea4 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -812,7 +812,6 @@ xfs_writepage_map( ssize_t len = i_blocksize(inode); int error = 0; int count = 0; - bool uptodate = true; loff_t file_offset; /* file offset of page */ unsigned poffset; /* offset into page */ @@ -840,7 +839,6 @@ xfs_writepage_map( if (bh && !buffer_uptodate(bh)) { if (PageUptodate(page)) ASSERT(buffer_mapped(bh)); - uptodate = false; bh = bh->b_this_page; continue; } @@ -880,9 +878,6 @@ xfs_writepage_map( count++; } - if (uptodate && poffset == PAGE_SIZE) - SetPageUptodate(page); - ASSERT(wpc->ioend || list_empty(&submit_list)); out: