diff mbox

xfs_bmap: don't reject -e

Message ID 20180621184945.GE4838@magnolia (mailing list archive)
State Accepted
Headers show

Commit Message

Darrick J. Wong June 21, 2018, 6:49 p.m. UTC 
From: Darrick J. Wong <darrick.wong@oracle.com>

The xfs_io bmap command has an -e switch that prints delalloc extents
without fsync'ing the file first.  The xfs_bmap manpage says it'll pass
-e through, but it doesn't.  Fix the script and fix the weird manpage
discrepancy where it doesn't list -e in the available options but
discusses it anyway.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 io/xfs_bmap.sh      |    5 +++--
 man/man8/xfs_bmap.8 |    2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Eric Sandeen June 21, 2018, 7:32 p.m. UTC | #1 
On 6/21/18 1:49 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> The xfs_io bmap command has an -e switch that prints delalloc extents
> without fsync'ing the file first.  The xfs_bmap manpage says it'll pass
> -e through, but it doesn't.  Fix the script and fix the weird manpage
> discrepancy where it doesn't list -e in the available options but
> discusses it anyway.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

need to fix it all up for "-c" as well, right?

and I think:

Fixes: 7536ce44f6 ("xfs_io: bmap should support querying CoW fork, shared blocks")

--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Darrick J. Wong June 21, 2018, 7:47 p.m. UTC | #2 
On Thu, Jun 21, 2018 at 02:32:44PM -0500, Eric Sandeen wrote:
> On 6/21/18 1:49 PM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> > 
> > The xfs_io bmap command has an -e switch that prints delalloc extents
> > without fsync'ing the file first.  The xfs_bmap manpage says it'll pass
> > -e through, but it doesn't.  Fix the script and fix the weird manpage
> > discrepancy where it doesn't list -e in the available options but
> > discusses it anyway.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> 
> need to fix it all up for "-c" as well, right?

The cow fork bmap only works if CONFIG_XFS_DEBUG=y (per review comment
when reflink was being developed) so I never bothered wiring it up from
xfs_bmap.sh, only xfs_io.

> and I think:
> 
> Fixes: 7536ce44f6 ("xfs_io: bmap should support querying CoW fork, shared blocks")

Ok.

--D

> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/io/xfs_bmap.sh b/io/xfs_bmap.sh
index b4e7992b..753d57cb 100755
--- a/io/xfs_bmap.sh
+++ b/io/xfs_bmap.sh
@@ -5,14 +5,15 @@ 
 
 OPTS=""
 VERSION=false
-USAGE="Usage: xfs_bmap [-adlpvV] [-n nx] file..."
+USAGE="Usage: xfs_bmap [-adelpvV] [-n nx] file..."
 DIRNAME=`dirname $0`
 
-while getopts "adln:pvV" c
+while getopts "adeln:pvV" c
 do
 	case $c in
 	a)	OPTS=$OPTS" -a";;
 	d)	OPTS=$OPTS" -d";;
+	e)	OPTS=$OPTS" -e";;
 	l)	OPTS=$OPTS" -l";;
 	n)	OPTS=$OPTS" -n "$OPTARG;;
 	p)	OPTS=$OPTS" -p";;
diff --git a/man/man8/xfs_bmap.8 b/man/man8/xfs_bmap.8
index c7255192..ae923481 100644
--- a/man/man8/xfs_bmap.8
+++ b/man/man8/xfs_bmap.8
@@ -4,7 +4,7 @@  xfs_bmap \- print block mapping for an XFS file
 .SH SYNOPSIS
 .B xfs_bmap
 [
-.B \-adlpv
+.B \-adelpv
 ] [
 .B \-n
 .I num_extents