From patchwork Tue Jul 10 09:41:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zorro Lang X-Patchwork-Id: 10516679 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 826B86054E for ; Tue, 10 Jul 2018 09:41:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7288528BA5 for ; Tue, 10 Jul 2018 09:41:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6560928CEF; Tue, 10 Jul 2018 09:41:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 07C2F28BA8 for ; Tue, 10 Jul 2018 09:41:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751309AbeGJJlg (ORCPT ); Tue, 10 Jul 2018 05:41:36 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:45342 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751194AbeGJJlf (ORCPT ); Tue, 10 Jul 2018 05:41:35 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 44D35402315B; Tue, 10 Jul 2018 09:41:35 +0000 (UTC) Received: from dhcp-12-245.nay.redhat.com (dhcp-12-245.nay.redhat.com [10.66.12.245]) by smtp.corp.redhat.com (Postfix) with ESMTP id F3B23111C4BE; Tue, 10 Jul 2018 09:41:33 +0000 (UTC) From: Zorro Lang To: fstests@vger.kernel.org Cc: linux-xfs@vger.kernel.org Subject: [PATCH] common/xfs: remove bad xfs_repair -t option Date: Tue, 10 Jul 2018 17:41:29 +0800 Message-Id: <20180710094129.1052-1-zlang@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Tue, 10 Jul 2018 09:41:35 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Tue, 10 Jul 2018 09:41:35 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'zlang@redhat.com' RCPT:'' Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The xfs_repair "-t" option shouldn't be used alone. An interval must follow the -t option, or xfs_repair will report errors. And only modify reporting interval is useless, if we don't enable ag_stride. Signed-off-by: Zorro Lang Reviewed-by: Darrick J. Wong Reviewed-by: Eric Sandeen --- Hi, I don't know why we must need the -t option for xfs_repair, I can't find any description to explain it. But I can find an explanation about why we use "-t" for _xfs_check. # xfs_check runs out of memory on large files, so even providing the test # option (-t) to avoid indexing the free space trees doesn't make it pass on # large filesystems. Avoid it. The -t option for xfs_repair is totally different with it for xfs_check, maybe -m option is more useful if we think about the memory size. And the -t option need to work with -o ag_stride together. I'd like to remove the "-t" option directly, due to I really don't know why we need it, or how to give it a proper number. If the original author knows why we need it, and can give me some suggestions, please help. Thanks, Zorro common/xfs | 1 - 1 file changed, 1 deletion(-) diff --git a/common/xfs b/common/xfs index ecf54bbf..61a3c2d9 100644 --- a/common/xfs +++ b/common/xfs @@ -193,7 +193,6 @@ _scratch_xfs_repair() SCRATCH_OPTIONS="-l$SCRATCH_LOGDEV" [ "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_RTDEV" ] && \ SCRATCH_OPTIONS=$SCRATCH_OPTIONS" -r$SCRATCH_RTDEV" - [ "$LARGE_SCRATCH_DEV" = yes ] && SCRATCH_OPTIONS=$SCRATCH_OPTIONS" -t" $XFS_REPAIR_PROG $SCRATCH_OPTIONS $* $SCRATCH_DEV }