Message ID | 20180719134919.29939-3-bfoster@redhat.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
On Thu, Jul 19, 2018 at 09:49:07AM -0400, Brian Foster wrote: > xlog_finish_defer_ops() processes the deferred operations collected > over the entire intent recovery sequence. We can't xfs_defer_init() > here because the dfops is already populated. Attach it manually and > eliminate the last caller of xfs_defer_finish() that doesn't pass > ->t_dfops. Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c index cbac943896f4..3289811eb076 100644 --- a/fs/xfs/xfs_log_recover.c +++ b/fs/xfs/xfs_log_recover.c @@ -4854,6 +4854,8 @@ xlog_finish_defer_ops( 0, XFS_TRANS_RESERVE, &tp); if (error) return error; + /* dfops is already populated so assign it manually */ + tp->t_dfops = dfops; error = xfs_defer_finish(&tp, dfops); if (error)
xlog_finish_defer_ops() processes the deferred operations collected over the entire intent recovery sequence. We can't xfs_defer_init() here because the dfops is already populated. Attach it manually and eliminate the last caller of xfs_defer_finish() that doesn't pass ->t_dfops. Signed-off-by: Brian Foster <bfoster@redhat.com> --- fs/xfs/xfs_log_recover.c | 2 ++ 1 file changed, 2 insertions(+)