diff mbox series

xfs: make xfs_file_remap_range() static

Message ID 20181115011217.104363-1-ebiggers@kernel.org (mailing list archive)
State Accepted
Headers show
Series xfs: make xfs_file_remap_range() static | expand

Commit Message

Eric Biggers Nov. 15, 2018, 1:12 a.m. UTC
From: Eric Biggers <ebiggers@google.com>

xfs_file_remap_range() is only used in fs/xfs/xfs_file.c, so make it
static.

This addresses a gcc warning when -Wmissing-prototypes is enabled.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 fs/xfs/xfs_file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Darrick J. Wong Nov. 15, 2018, 5:58 a.m. UTC | #1
On Wed, Nov 14, 2018 at 05:12:17PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> xfs_file_remap_range() is only used in fs/xfs/xfs_file.c, so make it
> static.
> 
> This addresses a gcc warning when -Wmissing-prototypes is enabled.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  fs/xfs/xfs_file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index 53c9ab8fb777f..e47425071e654 100644
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -920,7 +920,7 @@ xfs_file_fallocate(
>  }
>  
>  
> -loff_t
> +STATIC loff_t
>  xfs_file_remap_range(
>  	struct file		*file_in,
>  	loff_t			pos_in,
> -- 
> 2.19.1.930.g4563a0d9d0-goog
>
Allison Henderson Nov. 15, 2018, 7:21 p.m. UTC | #2
On 11/14/18 6:12 PM, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> xfs_file_remap_range() is only used in fs/xfs/xfs_file.c, so make it
> static.
> 
> This addresses a gcc warning when -Wmissing-prototypes is enabled.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>   fs/xfs/xfs_file.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index 53c9ab8fb777f..e47425071e654 100644
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -920,7 +920,7 @@ xfs_file_fallocate(
>   }
>   
>   
> -loff_t
> +STATIC loff_t
>   xfs_file_remap_range(
>   	struct file		*file_in,
>   	loff_t			pos_in,
> 

Looks ok to me.  You can add my review:
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>

Thanks!
Allison
diff mbox series

Patch

diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index 53c9ab8fb777f..e47425071e654 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -920,7 +920,7 @@  xfs_file_fallocate(
 }
 
 
-loff_t
+STATIC loff_t
 xfs_file_remap_range(
 	struct file		*file_in,
 	loff_t			pos_in,