diff mbox series

[3/2] xfs/010: use correct type for finobt corrupting

Message ID 20190226034628.GB7159@magnolia (mailing list archive)
State Superseded, archived
Headers show
Series [1/2] misc: don't oom the box opening tmpfiles | expand

Commit Message

Darrick J. Wong Feb. 26, 2019, 3:46 a.m. UTC
From: Darrick J. Wong <darrick.wong@oracle.com>

Use 'type finobt' for corrupting the finobt.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 tests/xfs/010 |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Allison Henderson Feb. 26, 2019, 8:17 p.m. UTC | #1
On 2/25/19 8:46 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Use 'type finobt' for corrupting the finobt.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>   tests/xfs/010 |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/xfs/010 b/tests/xfs/010
> index ee1595c8..e220a651 100755
> --- a/tests/xfs/010
> +++ b/tests/xfs/010
> @@ -63,14 +63,14 @@ _corrupt_finobt_records()
>   			_filter_dbval`
>   
>   	# Corrupt a freecount value. This should never exceed 64.
> -	$XFS_DB_PROG -x -c "fsb $free_root" -c "type inobt" \
> +	$XFS_DB_PROG -x -c "fsb $free_root" -c "type finobt" \
>   		-c "write recs[1].freecount 70" $dev
>   
>   	# Create a corrupted non-free record, which should never appear in the
>   	# finobt.
> -	$XFS_DB_PROG -x -c "fsb $free_root" -c "type inobt" \
> +	$XFS_DB_PROG -x -c "fsb $free_root" -c "type finobt" \
>   		 -c "write recs[2].freecount 0" $dev
> -	$XFS_DB_PROG -x -c "fsb $free_root" -c "type inobt" \
> +	$XFS_DB_PROG -x -c "fsb $free_root" -c "type finobt" \
>   		-c "write recs[2].free 0" $dev
>   }
>   
> 

Good catch, this looks like a pretty old test too.  Thanks for the fix!

Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
diff mbox series

Patch

diff --git a/tests/xfs/010 b/tests/xfs/010
index ee1595c8..e220a651 100755
--- a/tests/xfs/010
+++ b/tests/xfs/010
@@ -63,14 +63,14 @@  _corrupt_finobt_records()
 			_filter_dbval`
 
 	# Corrupt a freecount value. This should never exceed 64.
-	$XFS_DB_PROG -x -c "fsb $free_root" -c "type inobt" \
+	$XFS_DB_PROG -x -c "fsb $free_root" -c "type finobt" \
 		-c "write recs[1].freecount 70" $dev
 
 	# Create a corrupted non-free record, which should never appear in the
 	# finobt.
-	$XFS_DB_PROG -x -c "fsb $free_root" -c "type inobt" \
+	$XFS_DB_PROG -x -c "fsb $free_root" -c "type finobt" \
 		 -c "write recs[2].freecount 0" $dev
-	$XFS_DB_PROG -x -c "fsb $free_root" -c "type inobt" \
+	$XFS_DB_PROG -x -c "fsb $free_root" -c "type finobt" \
 		-c "write recs[2].free 0" $dev
 }