| Message ID | 20190830102227.20932-1-hch@lst.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | xfsprogs: provide a few compatibility typedefs | expand |
On Fri, Aug 30, 2019 at 12:22:27PM +0200, Christoph Hellwig wrote: > Add back four typedefs that allow xfsdump to compile against the > headers from the latests xfsprogs. > > Reported-by: Murphy Zhou <jencce.kernel@gmail.com> > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > include/xfs.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/xfs.h b/include/xfs.h > index f2f675df..9ae067dc 100644 > --- a/include/xfs.h > +++ b/include/xfs.h > @@ -37,4 +37,13 @@ extern int xfs_assert_largefile[sizeof(off_t)-8]; > #include <xfs/xfs_types.h> > #include <xfs/xfs_fs.h> > > +/* > + * Backards compatibility for users of this header, now that the kernel > + * removed these typedefs from xfs_fs.h. > + */ > +typedef struct xfs_bstat xfs_bstat_t; > +typedef struct xfs_fsop_bulkreq xfs_fsop_bulkreq_t; > +typedef struct xfs_fsop_geom_v1 xfs_fsop Missing a semicolon here? --D > +typedef struct xfs_inogrp xfs_inogrp_t; > + > #endif /* __XFS_H__ */ > -- > 2.20.1 >
On Fri, Aug 30, 2019 at 07:43:35AM -0700, Darrick J. Wong wrote: > On Fri, Aug 30, 2019 at 12:22:27PM +0200, Christoph Hellwig wrote: > > Add back four typedefs that allow xfsdump to compile against the > > headers from the latests xfsprogs. > > > > Reported-by: Murphy Zhou <jencce.kernel@gmail.com> > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > --- > > include/xfs.h | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/include/xfs.h b/include/xfs.h > > index f2f675df..9ae067dc 100644 > > --- a/include/xfs.h > > +++ b/include/xfs.h > > @@ -37,4 +37,13 @@ extern int xfs_assert_largefile[sizeof(off_t)-8]; > > #include <xfs/xfs_types.h> > > #include <xfs/xfs_fs.h> > > > > +/* > > + * Backards compatibility for users of this header, now that the kernel > > + * removed these typedefs from xfs_fs.h. > > + */ > > +typedef struct xfs_bstat xfs_bstat_t; > > +typedef struct xfs_fsop_bulkreq xfs_fsop_bulkreq_t; > > +typedef struct xfs_fsop_geom_v1 xfs_fsop > > Missing a semicolon here? Yes. And that did blew up when I compiled it and then I fixed it. Guess I failed to ammend the commit afterwards, sigh..
diff --git a/include/xfs.h b/include/xfs.h index f2f675df..9ae067dc 100644 --- a/include/xfs.h +++ b/include/xfs.h @@ -37,4 +37,13 @@ extern int xfs_assert_largefile[sizeof(off_t)-8]; #include <xfs/xfs_types.h> #include <xfs/xfs_fs.h> +/* + * Backards compatibility for users of this header, now that the kernel + * removed these typedefs from xfs_fs.h. + */ +typedef struct xfs_bstat xfs_bstat_t; +typedef struct xfs_fsop_bulkreq xfs_fsop_bulkreq_t; +typedef struct xfs_fsop_geom_v1 xfs_fsop +typedef struct xfs_inogrp xfs_inogrp_t; + #endif /* __XFS_H__ */
Add back four typedefs that allow xfsdump to compile against the headers from the latests xfsprogs. Reported-by: Murphy Zhou <jencce.kernel@gmail.com> Signed-off-by: Christoph Hellwig <hch@lst.de> --- include/xfs.h | 9 +++++++++ 1 file changed, 9 insertions(+)