diff mbox series

[03/11] iomap: warn on inline maps in iomap_writepage_map

Message ID 20191001071152.24403-4-hch@lst.de (mailing list archive)
State Superseded
Headers show
Series [01/11] iomap: add tracing for the readpage / readpages | expand

Commit Message

Christoph Hellwig Oct. 1, 2019, 7:11 a.m. UTC
And inline mapping should never mark the page dirty and thus never end up
in writepages.  Add a check for that condition and warn if it happens.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
 fs/iomap/buffered-io.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series


diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index 3444f968e739..61f067b3261b 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -1409,6 +1409,8 @@  iomap_writepage_map(struct iomap_writepage_ctx *wpc,
 		error = wpc->ops->map_blocks(wpc, inode, file_offset);
 		if (error)
+		if (WARN_ON_ONCE(wpc->iomap.type == IOMAP_INLINE))
+			continue;
 		if (wpc->iomap.type == IOMAP_HOLE)
 		iomap_add_to_ioend(inode, file_offset, page, iop, wpc, wbc,