diff mbox series

[10/31] xfs: turn xfs_da_args.value into a void pointer

Message ID	20200221141154.476496-11-hch@lst.de (mailing list archive)
State	Superseded
Headers	show Return-Path: <SRS0=UV4a=4J=vger.kernel.org=linux-xfs-owner@kernel.org> From: Christoph Hellwig <hch@lst.de> To: linux-xfs@vger.kernel.org Cc: Allison Collins <allison.henderson@oracle.com>, "Darrick J . Wong" <darrick.wong@oracle.com> Subject: [PATCH 10/31] xfs: turn xfs_da_args.value into a void pointer Date: Fri, 21 Feb 2020 06:11:33 -0800 Message-Id: <20200221141154.476496-11-hch@lst.de> In-Reply-To: <20200221141154.476496-1-hch@lst.de> References: <20200221141154.476496-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk
Series	[01/31] xfs: reject invalid flags combinations in XFS_IOC_ATTRLIST_BY_HANDLE \| expand [01/31] xfs: reject invalid flags combinations in XFS_IOC_ATTRLIST_BY_HANDLE [02/31] xfs: remove the ATTR_INCOMPLETE flag [03/31] xfs: merge xfs_attr_remove into xfs_attr_set [04/31] xfs: merge xfs_attrmulti_attr_remove into xfs_attrmulti_attr_set [05/31] xfs: use strndup_user in XFS_IOC_ATTRMULTI_BY_HANDLE [06/31] xfs: factor out a helper for a single XFS_IOC_ATTRMULTI_BY_HANDLE op [07/31] xfs: remove the name == NULL check from xfs_attr_args_init [08/31] xfs: remove the MAXNAMELEN check from xfs_attr_args_init [09/31] xfs: move struct xfs_da_args to xfs_types.h [10/31] xfs: turn xfs_da_args.value into a void pointer [11/31] xfs: pass an initialized xfs_da_args structure to xfs_attr_set [12/31] xfs: pass an initialized xfs_da_args to xfs_attr_get [13/31] xfs: remove the xfs_inode argument to xfs_attr_get_ilocked [14/31] xfs: remove ATTR_KERNOVAL [15/31] xfs: remove ATTR_ALLOC and XFS_DA_OP_ALLOCVAL [16/31] xfs: replace ATTR_KERNOTIME with XFS_DA_OP_NOTIME [17/31] xfs: factor out a xfs_attr_match helper [18/31] xfs: cleanup struct xfs_attr_list_context [19/31] xfs: remove the unused ATTR_ENTRY macro [20/31] xfs: open code ATTR_ENTSIZE [21/31] xfs: move the legacy xfs_attr_list to xfs_ioctl.c [22/31] xfs: rename xfs_attr_list_int to xfs_attr_list [23/31] xfs: lift common checks into xfs_ioc_attr_list [24/31] xfs: lift buffer allocation into xfs_ioc_attr_list [25/31] xfs: lift cursor copy in/out into xfs_ioc_attr_list [26/31] xfs: improve xfs_forget_acl [27/31] xfs: clean up the ATTR_REPLACE checks [28/31] xfs: clean up the attr flag confusion [29/31] xfs: remove XFS_DA_OP_INCOMPLETE [30/31] xfs: embedded the attrlist cursor into struct xfs_attr_list_context [31/31] xfs: clean up bufsize alignment in xfs_ioc_attr_list

Commit Message

Christoph Hellwig Feb. 21, 2020, 2:11 p.m. UTC

The xattr values are blobs and should not be typed.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 fs/xfs/libxfs/xfs_types.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/fs/xfs/libxfs/xfs_types.h b/fs/xfs/libxfs/xfs_types.h
index e2711d119665..634814dd1d10 100644
--- a/fs/xfs/libxfs/xfs_types.h
+++ b/fs/xfs/libxfs/xfs_types.h
@@ -192,7 +192,7 @@  typedef struct xfs_da_args {
 	const uint8_t	*name;		/* string (maybe not NULL terminated) */
 	int		namelen;	/* length of string (maybe no NULL) */
 	uint8_t		filetype;	/* filetype of inode for directories */
-	uint8_t		*value;		/* set of bytes (maybe contain NULLs) */
+	void		*value;		/* set of bytes (maybe contain NULLs) */
 	int		valuelen;	/* length of value */
 	int		flags;		/* argument flags (eg: ATTR_NOCREATE) */
 	xfs_dahash_t	hashval;	/* hash value of name */