Message ID | 20200221154132.GQ9506@magnolia (mailing list archive) |
---|---|
State | Accepted |
Headers | show |
Series | xfs: improve error message when we can't allocate memory for xfs_buf | expand |
On Fri, Feb 21, 2020 at 07:41:32AM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@oracle.com> > > If xfs_buf_get_map can't allocate enough memory for the buffer it's > trying to create, it'll cough up an error about not being able to > allocate "pagesn". That's not particularly helpful (and if we're really > out of memory the message is very spammy) so change the message to tell > us how many pages were actually requested, and ratelimit it too. > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index 0ceaa172545b..f8e4fee206ff 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -727,8 +727,9 @@ xfs_buf_get_map( if (!bp->b_addr) { error = _xfs_buf_map_pages(bp, flags); if (unlikely(error)) { - xfs_warn(target->bt_mount, - "%s: failed to map pagesn", __func__); + xfs_warn_ratelimited(target->bt_mount, + "%s: failed to map %u pages", __func__, + bp->b_page_count); xfs_buf_relse(bp); return error; }