diff mbox series

[09/32] xfs: turn xfs_da_args.value into a void pointer

Message ID	20200226202306.871241-10-hch@lst.de (mailing list archive)
State	Accepted
Headers	show Return-Path: <SRS0=HAJZ=4O=vger.kernel.org=linux-xfs-owner@kernel.org> From: Christoph Hellwig <hch@lst.de> To: linux-xfs@vger.kernel.org Cc: Dave Chinner <dchinner@redhat.com>, "Darrick J . Wong" <darrick.wong@oracle.com> Subject: [PATCH 09/32] xfs: turn xfs_da_args.value into a void pointer Date: Wed, 26 Feb 2020 12:22:43 -0800 Message-Id: <20200226202306.871241-10-hch@lst.de> In-Reply-To: <20200226202306.871241-1-hch@lst.de> References: <20200226202306.871241-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk
Series	[01/32] xfs: reject invalid flags combinations in XFS_IOC_ATTRLIST_BY_HANDLE \| expand [01/32] xfs: reject invalid flags combinations in XFS_IOC_ATTRLIST_BY_HANDLE [02/32] xfs: remove the ATTR_INCOMPLETE flag [03/32] xfs: merge xfs_attr_remove into xfs_attr_set [04/32] xfs: merge xfs_attrmulti_attr_remove into xfs_attrmulti_attr_set [05/32] xfs: use strndup_user in XFS_IOC_ATTRMULTI_BY_HANDLE [06/32] xfs: factor out a helper for a single XFS_IOC_ATTRMULTI_BY_HANDLE op [07/32] xfs: remove the name == NULL check from xfs_attr_args_init [08/32] xfs: remove the MAXNAMELEN check from xfs_attr_args_init [09/32] xfs: turn xfs_da_args.value into a void pointer [10/32] xfs: pass an initialized xfs_da_args structure to xfs_attr_set [11/32] xfs: pass an initialized xfs_da_args to xfs_attr_get [12/32] xfs: remove the xfs_inode argument to xfs_attr_get_ilocked [13/32] xfs: remove ATTR_KERNOVAL [14/32] xfs: remove ATTR_ALLOC and XFS_DA_OP_ALLOCVAL [15/32] xfs: replace ATTR_KERNOTIME with XFS_DA_OP_NOTIME [16/32] xfs: factor out a xfs_attr_match helper [17/32] xfs: cleanup struct xfs_attr_list_context [18/32] xfs: remove the unused ATTR_ENTRY macro [19/32] xfs: open code ATTR_ENTSIZE [20/32] xfs: move the legacy xfs_attr_list to xfs_ioctl.c [21/32] xfs: rename xfs_attr_list_int to xfs_attr_list [22/32] xfs: lift common checks into xfs_ioc_attr_list [23/32] xfs: lift buffer allocation into xfs_ioc_attr_list [24/32] xfs: lift cursor copy in/out into xfs_ioc_attr_list [25/32] xfs: improve xfs_forget_acl [26/32] xfs: clean up the ATTR_REPLACE checks [27/32] xfs: clean up the attr flag confusion [28/32] xfs: remove XFS_DA_OP_INCOMPLETE [29/32] xfs: embedded the attrlist cursor into struct xfs_attr_list_context [30/32] xfs: clean up bufsize alignment in xfs_ioc_attr_list [31/32] xfs: only allocate the buffer size actually needed in __xfs_set_acl [32/32] xfs: switch xfs_attrmulti_attr_get to lazy attr buffer allocation

Commit Message

Christoph Hellwig Feb. 26, 2020, 8:22 p.m. UTC

The xattr values are blobs and should not be typed.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 fs/xfs/libxfs/xfs_da_btree.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/fs/xfs/libxfs/xfs_da_btree.h b/fs/xfs/libxfs/xfs_da_btree.h
index 0f4fbb0889ff..0967d1bd3ceb 100644
--- a/fs/xfs/libxfs/xfs_da_btree.h
+++ b/fs/xfs/libxfs/xfs_da_btree.h
@@ -57,7 +57,7 @@  typedef struct xfs_da_args {
 	const uint8_t		*name;		/* string (maybe not NULL terminated) */
 	int		namelen;	/* length of string (maybe no NULL) */
 	uint8_t		filetype;	/* filetype of inode for directories */
-	uint8_t		*value;		/* set of bytes (maybe contain NULLs) */
+	void		*value;		/* set of bytes (maybe contain NULLs) */
 	int		valuelen;	/* length of value */
 	int		flags;		/* argument flags (eg: ATTR_NOCREATE) */
 	xfs_dahash_t	hashval;	/* hash value of name */