Message ID | 20200625232848.14465-16-allison.henderson@oracle.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show
Return-Path: <SRS0=UnAH=AG=vger.kernel.org=linux-xfs-owner@kernel.org> Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6995660D for <patchwork-linux-xfs@patchwork.kernel.org>; Thu, 25 Jun 2020 23:31:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5127120899 for <patchwork-linux-xfs@patchwork.kernel.org>; Thu, 25 Jun 2020 23:31:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="USMlBUc0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725355AbgFYXbV (ORCPT <rfc822;patchwork-linux-xfs@patchwork.kernel.org>); Thu, 25 Jun 2020 19:31:21 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:54474 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726101AbgFYXbG (ORCPT <rfc822;linux-xfs@vger.kernel.org>); Thu, 25 Jun 2020 19:31:06 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 05PNQvNH038328 for <linux-xfs@vger.kernel.org>; Thu, 25 Jun 2020 23:31:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : in-reply-to : references; s=corp-2020-01-29; bh=nAZFlkZuddcB3sbmOkaM7HDxJWdv3RpI79cFjPKiU9c=; b=USMlBUc0f1Yo4GY21gtm5WoSYZTQicPQ5FO/M/pn3VI6onrHtHCleSzylO0tKb2ifdSF ORCqBafe4aYovykfmHXNarZRXR0jz1vxBPZFXn9uI/qWB9K1Ij8vEowBcHuzod4k9DX/ BqL+rrPPIrHNnMtZo8dN4zJ6q6zNHDwG3KZl0KO9U6vqcZnpb93yiTxiIlwLkyEaxYtR 4LTXKahH2VHeMMOivU36VpiJLrDhpCjVxWw64MoKKChjKJfCipZ3MyICRleqLVewd8F+ qNjEGQbOyKojwrVX3YXUCppBn7dm9UDA+yol+2TvCx1xmfaxtlNrGjiO8OHj5vkxODGK fQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 31uut5u9y0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for <linux-xfs@vger.kernel.org>; Thu, 25 Jun 2020 23:31:05 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 05PNSIFK110896 for <linux-xfs@vger.kernel.org>; Thu, 25 Jun 2020 23:29:04 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 31uur9r3m4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <linux-xfs@vger.kernel.org>; Thu, 25 Jun 2020 23:29:04 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 05PNT4wT007694 for <linux-xfs@vger.kernel.org>; Thu, 25 Jun 2020 23:29:04 GMT Received: from localhost.localdomain (/67.1.142.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 25 Jun 2020 23:29:03 +0000 From: Allison Collins <allison.henderson@oracle.com> To: linux-xfs@vger.kernel.org Subject: [PATCH v10 15/26] xfsprogs: Remove xfs_trans_roll in xfs_attr_node_removename Date: Thu, 25 Jun 2020 16:28:37 -0700 Message-Id: <20200625232848.14465-16-allison.henderson@oracle.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200625232848.14465-1-allison.henderson@oracle.com> References: <20200625232848.14465-1-allison.henderson@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9663 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 malwarescore=0 suspectscore=1 mlxlogscore=999 adultscore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006250136 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9663 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 adultscore=0 spamscore=0 suspectscore=1 phishscore=0 impostorscore=0 cotscore=-2147483648 priorityscore=1501 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006250136 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: <linux-xfs.vger.kernel.org> X-Mailing-List: linux-xfs@vger.kernel.org |
Series |
Delay Ready Attributes
|
expand
|
diff --git a/libxfs/xfs_attr.c b/libxfs/xfs_attr.c index 0b81bf5..a743900 100644 --- a/libxfs/xfs_attr.c +++ b/libxfs/xfs_attr.c @@ -1148,10 +1148,6 @@ xfs_attr_node_removename( if (error) goto out; - error = xfs_trans_roll_inode(&args->trans, args->dp); - if (error) - goto out; - error = xfs_attr_rmtval_invalidate(args); if (error) return error;
The xfs_trans_roll in _removename is not needed because invalidating blocks is an incore-only change. This is analogous to the non-remote remove case where an entry is removed and a potential dabtree join occurs under the same transaction. Signed-off-by: Allison Collins <allison.henderson@oracle.com> --- libxfs/xfs_attr.c | 4 ---- 1 file changed, 4 deletions(-)