diff mbox series

[6/6] mkfs: remove a couple of unused function parameters

Message ID 20200824203724.13477-7-ailiop@suse.com
State Accepted
Headers show
Series xfsprogs: blockdev dax detection and warnings | expand

Commit Message

Anthony Iliopoulos Aug. 24, 2020, 8:37 p.m. UTC
initialise_mount does not use mkfs_params, and initialise_ag_headers
does not use the xfs_sb param, remove them.

Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
---
 mkfs/xfs_mkfs.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Eric Sandeen Sept. 28, 2020, 9:50 p.m. UTC | #1
On 8/24/20 3:37 PM, Anthony Iliopoulos wrote:
> initialise_mount does not use mkfs_params, and initialise_ag_headers
> does not use the xfs_sb param, remove them.
> 
> Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  mkfs/xfs_mkfs.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index 1f142f78e677..03bbe3b4697d 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -3243,7 +3243,6 @@ start_superblock_setup(
>  
>  static void
>  initialise_mount(
> -	struct mkfs_params	*cfg,
>  	struct xfs_mount	*mp,
>  	struct xfs_sb		*sbp)
>  {
> @@ -3431,7 +3430,6 @@ static void
>  initialise_ag_headers(
>  	struct mkfs_params	*cfg,
>  	struct xfs_mount	*mp,
> -	struct xfs_sb		*sbp,
>  	xfs_agnumber_t		agno,
>  	int			*worst_freelist,
>  	struct list_head	*buffer_list)
> @@ -3776,7 +3774,7 @@ main(
>  	 * provided functions to determine on-disk format information.
>  	 */
>  	start_superblock_setup(&cfg, mp, sbp);
> -	initialise_mount(&cfg, mp, sbp);
> +	initialise_mount(mp, sbp);
>  
>  	/*
>  	 * With the mount set up, we can finally calculate the log size
> @@ -3829,7 +3827,7 @@ main(
>  	 */
>  	INIT_LIST_HEAD(&buffer_list);
>  	for (agno = 0; agno < cfg.agcount; agno++) {
> -		initialise_ag_headers(&cfg, mp, sbp, agno, &worst_freelist,
> +		initialise_ag_headers(&cfg, mp, agno, &worst_freelist,
>  				&buffer_list);
>  
>  		if (agno % 16)
>
diff mbox series

Patch

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 1f142f78e677..03bbe3b4697d 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -3243,7 +3243,6 @@  start_superblock_setup(
 
 static void
 initialise_mount(
-	struct mkfs_params	*cfg,
 	struct xfs_mount	*mp,
 	struct xfs_sb		*sbp)
 {
@@ -3431,7 +3430,6 @@  static void
 initialise_ag_headers(
 	struct mkfs_params	*cfg,
 	struct xfs_mount	*mp,
-	struct xfs_sb		*sbp,
 	xfs_agnumber_t		agno,
 	int			*worst_freelist,
 	struct list_head	*buffer_list)
@@ -3776,7 +3774,7 @@  main(
 	 * provided functions to determine on-disk format information.
 	 */
 	start_superblock_setup(&cfg, mp, sbp);
-	initialise_mount(&cfg, mp, sbp);
+	initialise_mount(mp, sbp);
 
 	/*
 	 * With the mount set up, we can finally calculate the log size
@@ -3829,7 +3827,7 @@  main(
 	 */
 	INIT_LIST_HEAD(&buffer_list);
 	for (agno = 0; agno < cfg.agcount; agno++) {
-		initialise_ag_headers(&cfg, mp, sbp, agno, &worst_freelist,
+		initialise_ag_headers(&cfg, mp, agno, &worst_freelist,
 				&buffer_list);
 
 		if (agno % 16)