diff mbox series

[v12,14/32] xfsprogs: Remove xfs_trans_roll in xfs_attr_node_removename

Message ID 20200827002856.1131-15-allison.henderson@oracle.com
State New
Headers show
Series xfsprogs: Delayed Attributes | expand

Commit Message

Allison Henderson Aug. 27, 2020, 12:28 a.m. UTC
A transaction roll is not necessary immediately after setting the
INCOMPLETE flag when removing a node xattr entry with remote value
blocks. The remote block invalidation that immediately follows setting
the flag is an in-core only change. The next step after that is to start
unmapping the remote blocks from the attr fork, but the xattr remove
transaction reservation includes reservation for full tree splits of the
dabtree and bmap tree. The remote block unmap code will roll the
transaction as extents are unmapped and freed.

Signed-off-by: Allison Collins <allison.henderson@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
 libxfs/xfs_attr.c | 4 ----
 1 file changed, 4 deletions(-)
diff mbox series


diff --git a/libxfs/xfs_attr.c b/libxfs/xfs_attr.c
index 808c4c3..8bfd580 100644
--- a/libxfs/xfs_attr.c
+++ b/libxfs/xfs_attr.c
@@ -1148,10 +1148,6 @@  xfs_attr_node_removename(
 		if (error)
 			goto out;
-		error = xfs_trans_roll_inode(&args->trans, args->dp);
-		if (error)
-			goto out;
 		error = xfs_attr_rmtval_invalidate(args);
 		if (error)
 			return error;