diff mbox series

xfs: fix Kconfig asking about XFS_SUPPORT_V4 when XFS_FS=n

Message ID 20201012211157.GE6559@magnolia (mailing list archive)
State Accepted
Headers show
Series xfs: fix Kconfig asking about XFS_SUPPORT_V4 when XFS_FS=n | expand

Commit Message

Darrick J. Wong Oct. 12, 2020, 9:11 p.m. UTC 
From: Darrick J. Wong <darrick.wong@oracle.com>

Pavel Machek complained that the question about supporting deprecated
XFS v4 comes up even when XFS is disabled.  This clearly makes no sense,
so fix Kconfig.

Reported-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 fs/xfs/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Comments

Eric Sandeen Oct. 12, 2020, 9:23 p.m. UTC | #1 
On 10/12/20 4:11 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Pavel Machek complained that the question about supporting deprecated
> XFS v4 comes up even when XFS is disabled.  This clearly makes no sense,
> so fix Kconfig.
> 
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  fs/xfs/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
> index 5422227e9e93..9fac5ea8d0e4 100644
> --- a/fs/xfs/Kconfig
> +++ b/fs/xfs/Kconfig
> @@ -24,6 +24,7 @@ config XFS_FS
>  
>  config XFS_SUPPORT_V4
>  	bool "Support deprecated V4 (crc=0) format"
> +	depends on XFS_FS
>  	default y
>  	help
>  	  The V4 filesystem format lacks certain features that are supported
>
diff mbox series

Patch

diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
index 5422227e9e93..9fac5ea8d0e4 100644
--- a/fs/xfs/Kconfig
+++ b/fs/xfs/Kconfig
@@ -24,6 +24,7 @@  config XFS_FS
 
 config XFS_SUPPORT_V4
 	bool "Support deprecated V4 (crc=0) format"
+	depends on XFS_FS
 	default y
 	help
 	  The V4 filesystem format lacks certain features that are supported