diff mbox series

[v3] xfs: remove a stale comment from xfs_file_aio_write_checks()

Message ID 20210112191024.65206-1-ebiggers@kernel.org (mailing list archive)
State Accepted
Headers show
Series [v3] xfs: remove a stale comment from xfs_file_aio_write_checks() | expand

Commit Message

Eric Biggers Jan. 12, 2021, 7:10 p.m. UTC 
From: Eric Biggers <ebiggers@google.com>

The comment in xfs_file_aio_write_checks() about calling file_modified()
after dropping the ilock doesn't make sense, because the code that
unconditionally acquires and drops the ilock was removed by
commit 467f78992a07 ("xfs: reduce ilock hold times in
xfs_file_aio_write_checks").

Remove this outdated comment.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
---

v3: resent as standalone patch and added a Reviewed-by.

 fs/xfs/xfs_file.c | 6 ------
 1 file changed, 6 deletions(-)


base-commit: e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62
diff mbox series

Patch

diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index 5b0f93f738372..4927c6653f15d 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -389,12 +389,6 @@  xfs_file_aio_write_checks(
 	} else
 		spin_unlock(&ip->i_flags_lock);
 
-	/*
-	 * Updating the timestamps will grab the ilock again from
-	 * xfs_fs_dirty_inode, so we have to call it after dropping the
-	 * lock above.  Eventually we should look into a way to avoid
-	 * the pointless lock roundtrip.
-	 */
 	return file_modified(file);
 }