| Message ID | 20210121154526.1852176-8-bfoster@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | xfs: rework log quiesce to cover the log | expand |
On 1/21/21 8:45 AM, Brian Foster wrote: > These two calls are repeated at the beginning of xfs_log_quiesce(). > Drop them from xfs_quiesce_attr(). > > Signed-off-by: Brian Foster <bfoster@redhat.com> > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Looks ok to me Reviewed-by: Allison Henderson <allison.henderson@oracle.com> > --- > fs/xfs/xfs_super.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index 75ada867c665..8fc9044131fc 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -884,11 +884,6 @@ void > xfs_quiesce_attr( > struct xfs_mount *mp) > { > - cancel_delayed_work_sync(&mp->m_log->l_work); > - > - /* force the log to unpin objects from the now complete transactions */ > - xfs_log_force(mp, XFS_LOG_SYNC); > - > xfs_log_clean(mp); > } > >
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index 75ada867c665..8fc9044131fc 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -884,11 +884,6 @@ void xfs_quiesce_attr( struct xfs_mount *mp) { - cancel_delayed_work_sync(&mp->m_log->l_work); - - /* force the log to unpin objects from the now complete transactions */ - xfs_log_force(mp, XFS_LOG_SYNC); - xfs_log_clean(mp); }