| Message ID | 20210205003125.24463-2-bastiangermann@fishpost.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | debian: minor fixes | expand |
On Fri, Feb 05, 2021 at 01:31:23AM +0100, Bastian Germann wrote: > xfsprogs participates in dependency loops relevant to architecture > bootstrap. Identifying easily droppable dependencies, it was found > that xfsprogs does not use dh-python in any way. scrub/xfs_scrub_all.in and tools/xfsbuflock.py are the only python scripts in xfsprogs. We ship the first one as-is in the xfsprogs package and we don't ship the second one at all (it's a debugger tool). AFAICT neither of them really use dh-python, right? --D > > Reported-by: Helmut Grohne <helmut@subdivi.de> > Signed-off-by: Bastian Germann <bastiangermann@fishpost.de> > --- > debian/changelog | 6 ++++++ > debian/control | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/debian/changelog b/debian/changelog > index ce4a224d..7b0120c2 100644 > --- a/debian/changelog > +++ b/debian/changelog > @@ -1,3 +1,9 @@ > +xfsprogs (5.10.0-3) unstable; urgency=medium > + > + * Drop unused dh-python from Build-Depends (Closes: #981361) > + > + -- Bastian Germann <bastiangermann@fishpost.de> Fri, 05 Feb 2021 00:18:31 +0100 > + > xfsprogs (5.10.0-2) unstable; urgency=low > > * Team upload > diff --git a/debian/control b/debian/control > index b0eb1566..8975bd13 100644 > --- a/debian/control > +++ b/debian/control > @@ -3,7 +3,7 @@ Section: admin > Priority: optional > Maintainer: XFS Development Team <linux-xfs@vger.kernel.org> > Uploaders: Nathan Scott <nathans@debian.org>, Anibal Monsalve Salazar <anibal@debian.org>, Bastian Germann <bastiangermann@fishpost.de> > -Build-Depends: libinih-dev, uuid-dev, dh-autoreconf, debhelper (>= 5), gettext, libtool, libedit-dev, libblkid-dev (>= 2.17), linux-libc-dev, libdevmapper-dev, libattr1-dev, libicu-dev, dh-python, pkg-config > +Build-Depends: libinih-dev, uuid-dev, dh-autoreconf, debhelper (>= 5), gettext, libtool, libedit-dev, libblkid-dev (>= 2.17), linux-libc-dev, libdevmapper-dev, libattr1-dev, libicu-dev, pkg-config > Standards-Version: 4.0.0 > Homepage: https://xfs.wiki.kernel.org/ > > -- > 2.30.0 >
On 2/4/21 6:51 PM, Darrick J. Wong wrote: > On Fri, Feb 05, 2021 at 01:31:23AM +0100, Bastian Germann wrote: >> xfsprogs participates in dependency loops relevant to architecture >> bootstrap. Identifying easily droppable dependencies, it was found >> that xfsprogs does not use dh-python in any way. > > scrub/xfs_scrub_all.in and tools/xfsbuflock.py are the only python > scripts in xfsprogs. We ship the first one as-is in the xfsprogs > package and we don't ship the second one at all (it's a debugger tool). > > AFAICT neither of them really use dh-python, right? right, hence the dependency drop, so I think you're in violent agreement and as one of our resident debian-heads you could RVB this one too, Darrick? ;) -Eric
Am 05.02.21 um 01:51 schrieb Darrick J. Wong: > On Fri, Feb 05, 2021 at 01:31:23AM +0100, Bastian Germann wrote: >> xfsprogs participates in dependency loops relevant to architecture >> bootstrap. Identifying easily droppable dependencies, it was found >> that xfsprogs does not use dh-python in any way. > > scrub/xfs_scrub_all.in and tools/xfsbuflock.py are the only python > scripts in xfsprogs. We ship the first one as-is in the xfsprogs > package and we don't ship the second one at all (it's a debugger tool). > > AFAICT neither of them really use dh-python, right? That is right. dh-python is generally used at build time to generate packages with Python modules, i.e., with files in /usr/lib/python3/dist-packages. That is not the case in xfsprogs. For xfsprogs, python3 is only a runtime dependency and that is defined in the control file as well. > --D > >> >> Reported-by: Helmut Grohne <helmut@subdivi.de> >> Signed-off-by: Bastian Germann <bastiangermann@fishpost.de>
On Fri, Feb 05, 2021 at 07:05:12PM +0100, Bastian Germann wrote: > Am 05.02.21 um 01:51 schrieb Darrick J. Wong: > > On Fri, Feb 05, 2021 at 01:31:23AM +0100, Bastian Germann wrote: > > > xfsprogs participates in dependency loops relevant to architecture > > > bootstrap. Identifying easily droppable dependencies, it was found > > > that xfsprogs does not use dh-python in any way. > > > > scrub/xfs_scrub_all.in and tools/xfsbuflock.py are the only python > > scripts in xfsprogs. We ship the first one as-is in the xfsprogs > > package and we don't ship the second one at all (it's a debugger tool). > > > > AFAICT neither of them really use dh-python, right? > > That is right. dh-python is generally used at build time to generate > packages with Python modules, i.e., with files in > /usr/lib/python3/dist-packages. That is not the case in xfsprogs. > > For xfsprogs, python3 is only a runtime dependency and that is defined in > the control file as well. <nod> /me finally figures out exactly what dh_python does--I thought it was required for any package shipping any python anything, but I guess it's only for building and prepping library code and hence not needed for our single python script in /usr/sbin, so: Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > > > --D > > > > > > > > Reported-by: Helmut Grohne <helmut@subdivi.de> > > > Signed-off-by: Bastian Germann <bastiangermann@fishpost.de>
diff --git a/debian/changelog b/debian/changelog index ce4a224d..7b0120c2 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +xfsprogs (5.10.0-3) unstable; urgency=medium + + * Drop unused dh-python from Build-Depends (Closes: #981361) + + -- Bastian Germann <bastiangermann@fishpost.de> Fri, 05 Feb 2021 00:18:31 +0100 + xfsprogs (5.10.0-2) unstable; urgency=low * Team upload diff --git a/debian/control b/debian/control index b0eb1566..8975bd13 100644 --- a/debian/control +++ b/debian/control @@ -3,7 +3,7 @@ Section: admin Priority: optional Maintainer: XFS Development Team <linux-xfs@vger.kernel.org> Uploaders: Nathan Scott <nathans@debian.org>, Anibal Monsalve Salazar <anibal@debian.org>, Bastian Germann <bastiangermann@fishpost.de> -Build-Depends: libinih-dev, uuid-dev, dh-autoreconf, debhelper (>= 5), gettext, libtool, libedit-dev, libblkid-dev (>= 2.17), linux-libc-dev, libdevmapper-dev, libattr1-dev, libicu-dev, dh-python, pkg-config +Build-Depends: libinih-dev, uuid-dev, dh-autoreconf, debhelper (>= 5), gettext, libtool, libedit-dev, libblkid-dev (>= 2.17), linux-libc-dev, libdevmapper-dev, libattr1-dev, libicu-dev, pkg-config Standards-Version: 4.0.0 Homepage: https://xfs.wiki.kernel.org/
xfsprogs participates in dependency loops relevant to architecture bootstrap. Identifying easily droppable dependencies, it was found that xfsprogs does not use dh-python in any way. Reported-by: Helmut Grohne <helmut@subdivi.de> Signed-off-by: Bastian Germann <bastiangermann@fishpost.de> --- debian/changelog | 6 ++++++ debian/control | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-)