From patchwork Tue Mar 9 05:01:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chandan Babu R X-Patchwork-Id: 12124091 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D94BCC43619 for ; Tue, 9 Mar 2021 05:02:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4F84652A4 for ; Tue, 9 Mar 2021 05:02:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229530AbhCIFB7 (ORCPT ); Tue, 9 Mar 2021 00:01:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229544AbhCIFB5 (ORCPT ); Tue, 9 Mar 2021 00:01:57 -0500 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16317C06174A; Mon, 8 Mar 2021 21:01:57 -0800 (PST) Received: by mail-pj1-x102b.google.com with SMTP id fu20so234569pjb.2; Mon, 08 Mar 2021 21:01:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uxvyne9W6+6fgT0VNxza+ydo9Q6Co5gs3i28V+THoQM=; b=BcYZVnPZrM1Jww4so8OjegDZy9xsy6CzNSmziNRTQr1Ko0I06V7CVW6UZKoPjHRd9V cxkxEZb8R50wkXSmz/by2KDzNKHNMu1bpiKsxWKigys0vwDOSvqZ5ZS5Wa1HsPYV7POJ /1fCcG/w++QiO3NOg1yCylT17uXHsvtFawu5xauLRYuQbqDUd5RZa/QmPuDvVdi97do0 i7BWMWbJV6eZc5VFH/KBqmWScBcxf3fNwDM7uJ5l8TkOPCoq4ijHZHapLgHPm50UiGye HWNwi83lKfHFC750Mpuy2HdADc+nl7QCqFzI0MXmjEEhal4rJe6x5sD4OSHicfa3sGSe kWoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uxvyne9W6+6fgT0VNxza+ydo9Q6Co5gs3i28V+THoQM=; b=YlffWbrM5oSFARkxb4e/EbL2ZSX6CRHAxpetbYrBBfp0jp1kzciaq0OPyVW4gl+eI1 k6YWxLzyQzrWbQXq/4BmQ+wOiKXY1bqFciCdbNkiyyfNhsOPYw/wcIl99Rw7uvCq2cgf k6N9eNHBVqTdcj0ORImaFbDLx5ukc7kGUpSfe+6vgXVBwgXVYEELAiB1sdQK0Rv9g39G 8JGfSvbjh3ZEy2NIckB432V3sOsgBfsO8zf2+RPU3Q7bQ4tvJ6H/pgfz97Srz6kiQArq cOps22mJ1S8ieQ9m9H+lJ69R4mIMENk2GSJhVMETQqPpXv7fU2t7RjRSJeyey1JQqxPY oGzQ== X-Gm-Message-State: AOAM533M584rPUjM9szIsTHnuwUeHBzoGaJKRMQXeHBgOXoxWtHgp382 u4TsXm9dC3yd9vI2344CgyDDxpccuB8= X-Google-Smtp-Source: ABdhPJyfU//KsdYHO3lZdooi4iO25LfGY5qBN9NwSQFFtpkTYb9t3wt+osez0aVW1ODd3VKu6RHQlg== X-Received: by 2002:a17:90b:33c7:: with SMTP id lk7mr2708202pjb.95.1615266116487; Mon, 08 Mar 2021 21:01:56 -0800 (PST) Received: from localhost.localdomain ([122.179.125.254]) by smtp.gmail.com with ESMTPSA id a21sm5849577pfh.31.2021.03.08.21.01.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 21:01:56 -0800 (PST) From: Chandan Babu R To: fstests@vger.kernel.org Cc: Chandan Babu R , linux-xfs@vger.kernel.org, djwong@kernel.org Subject: [PATCH V6 08/13] xfs: Check for extent overflow when adding/removing dir entries Date: Tue, 9 Mar 2021 10:31:19 +0530 Message-Id: <20210309050124.23797-9-chandanrlinux@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210309050124.23797-1-chandanrlinux@gmail.com> References: <20210309050124.23797-1-chandanrlinux@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org This test verifies that XFS does not cause inode fork's extent count to overflow when adding/removing directory entries. Reviewed-by: Darrick J. Wong Signed-off-by: Chandan Babu R Reviewed-by: Allison Henderson --- tests/xfs/532 | 182 ++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/532.out | 17 +++++ tests/xfs/group | 1 + 3 files changed, 200 insertions(+) create mode 100755 tests/xfs/532 create mode 100644 tests/xfs/532.out diff --git a/tests/xfs/532 b/tests/xfs/532 new file mode 100755 index 00000000..b241ddeb --- /dev/null +++ b/tests/xfs/532 @@ -0,0 +1,182 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2021 Chandan Babu R. All Rights Reserved. +# +# FS QA Test 532 +# +# Verify that XFS does not cause inode fork's extent count to overflow when +# adding/removing directory entries. +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/inject +. ./common/populate + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +_supported_fs xfs +_require_scratch +_require_xfs_debug +_require_test_program "punch-alternating" +_require_xfs_io_error_injection "reduce_max_iextents" +_require_xfs_io_error_injection "bmap_alloc_minlen_extent" + +_scratch_mkfs_sized $((1024 * 1024 * 1024)) | _filter_mkfs >> $seqres.full 2> $tmp.mkfs +. $tmp.mkfs + +# Filesystems with directory block size greater than one FSB will not be tested, +# since "7 (i.e. XFS_DA_NODE_MAXDEPTH + 1 data block + 1 free block) * 2 (fsb +# count) = 14" is greater than the pseudo max extent count limit of 10. +# Extending the pseudo max limit won't help either. Consider the case where 1 +# FSB is 1k in size and 1 dir block is 64k in size (i.e. fsb count = 64). In +# this case, the pseudo max limit has to be greater than 7 * 64 = 448 extents. +if (( $dirbsize > $dbsize )); then + _notrun "Directory block size ($dirbsize) is larger than FSB size ($dbsize)" +fi + +echo "Format and mount fs" +_scratch_mkfs_sized $((1024 * 1024 * 1024)) >> $seqres.full +_scratch_mount >> $seqres.full + +echo "Consume free space" +fillerdir=$SCRATCH_MNT/fillerdir +nr_free_blks=$(stat -f -c '%f' $SCRATCH_MNT) +nr_free_blks=$((nr_free_blks * 90 / 100)) + +_fill_fs $((dbsize * nr_free_blks)) $fillerdir $dbsize 0 >> $seqres.full 2>&1 + +echo "Create fragmented filesystem" +for dentry in $(ls -1 $fillerdir/); do + $here/src/punch-alternating $fillerdir/$dentry >> $seqres.full +done + +echo "Inject reduce_max_iextents error tag" +_scratch_inject_error reduce_max_iextents 1 + +echo "Inject bmap_alloc_minlen_extent error tag" +_scratch_inject_error bmap_alloc_minlen_extent 1 + +dent_len=255 + +echo "* Create directory entries" + +testdir=$SCRATCH_MNT/testdir +mkdir $testdir + +nr_dents=$((dbsize * 20 / dent_len)) +for i in $(seq 1 $nr_dents); do + dentry="$(printf "%0255d" $i)" + touch ${testdir}/$dentry >> $seqres.full 2>&1 || break +done + +echo "Verify directory's extent count" +nextents=$(_xfs_get_fsxattr nextents $testdir) +if (( $nextents > 10 )); then + echo "Extent count overflow check failed: nextents = $nextents" + exit 1 +fi + +rm -rf $testdir + +echo "* Rename: Populate destination directory" + +dstdir=$SCRATCH_MNT/dstdir +mkdir $dstdir + +nr_dents=$((dirbsize * 20 / dent_len)) + +echo "Populate \$dstdir by moving new directory entries" +for i in $(seq 1 $nr_dents); do + dentry="$(printf "%0255d" $i)" + dentry=${SCRATCH_MNT}/${dentry} + touch $dentry || break + mv $dentry $dstdir >> $seqres.full 2>&1 || break +done + +rm $dentry + +echo "Verify \$dstdir's extent count" + +nextents=$(_xfs_get_fsxattr nextents $dstdir) +if (( $nextents > 10 )); then + echo "Extent count overflow check failed: nextents = $nextents" + exit 1 +fi + +rm -rf $dstdir + +echo "* Create multiple hard links to a single file" + +testdir=$SCRATCH_MNT/testdir +mkdir $testdir + +testfile=$SCRATCH_MNT/testfile +touch $testfile + +nr_dents=$((dirbsize * 20 / dent_len)) + +echo "Create multiple hardlinks" +for i in $(seq 1 $nr_dents); do + dentry="$(printf "%0255d" $i)" + ln $testfile ${testdir}/${dentry} >> $seqres.full 2>&1 || break +done + +rm $testfile + +echo "Verify directory's extent count" +nextents=$(_xfs_get_fsxattr nextents $testdir) +if (( $nextents > 10 )); then + echo "Extent count overflow check failed: nextents = $nextents" + exit 1 +fi + +rm -rf $testdir + +echo "* Create multiple symbolic links to a single file" + +testdir=$SCRATCH_MNT/testdir +mkdir $testdir + +testfile=$SCRATCH_MNT/testfile +touch $testfile + +nr_dents=$((dirbsize * 20 / dent_len)) + +echo "Create multiple symbolic links" +for i in $(seq 1 $nr_dents); do + dentry="$(printf "%0255d" $i)" + ln -s $testfile ${testdir}/${dentry} >> $seqres.full 2>&1 || break; +done + +rm $testfile + +echo "Verify directory's extent count" +nextents=$(_xfs_get_fsxattr nextents $testdir) +if (( $nextents > 10 )); then + echo "Extent count overflow check failed: nextents = $nextents" + exit 1 +fi + +rm -rf $testdir + +# success, all done +status=0 +exit diff --git a/tests/xfs/532.out b/tests/xfs/532.out new file mode 100644 index 00000000..2766c211 --- /dev/null +++ b/tests/xfs/532.out @@ -0,0 +1,17 @@ +QA output created by 532 +Format and mount fs +Consume free space +Create fragmented filesystem +Inject reduce_max_iextents error tag +Inject bmap_alloc_minlen_extent error tag +* Create directory entries +Verify directory's extent count +* Rename: Populate destination directory +Populate $dstdir by moving new directory entries +Verify $dstdir's extent count +* Create multiple hard links to a single file +Create multiple hardlinks +Verify directory's extent count +* Create multiple symbolic links to a single file +Create multiple symbolic links +Verify directory's extent count diff --git a/tests/xfs/group b/tests/xfs/group index 7e284841..77abeefa 100644 --- a/tests/xfs/group +++ b/tests/xfs/group @@ -529,3 +529,4 @@ 529 auto quick realtime growfs 530 auto quick punch zero insert collapse 531 auto quick attr +532 auto quick dir hardlink symlink