diff mbox series

xfs: ensure xfs_errortag_random_default matches XFS_ERRTAG_MAX

Message ID 20210309184205.18675-1-hsiangkao@aol.com (mailing list archive)
State Accepted
Headers show
Series xfs: ensure xfs_errortag_random_default matches XFS_ERRTAG_MAX | expand

Commit Message

Gao Xiang March 9, 2021, 6:42 p.m. UTC 
From: Gao Xiang <hsiangkao@redhat.com>

Add the BUILD_BUG_ON to xfs_errortag_add() in order to make sure that
the length of xfs_errortag_random_default matches XFS_ERRTAG_MAX when
building.

Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
---
 fs/xfs/xfs_error.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Darrick J. Wong March 9, 2021, 9:28 p.m. UTC | #1 
On Wed, Mar 10, 2021 at 02:42:05AM +0800, Gao Xiang wrote:
> From: Gao Xiang <hsiangkao@redhat.com>
> 
> Add the BUILD_BUG_ON to xfs_errortag_add() in order to make sure that
> the length of xfs_errortag_random_default matches XFS_ERRTAG_MAX when
> building.
> 
> Signed-off-by: Gao Xiang <hsiangkao@redhat.com>

Yay!
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_error.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c
> index 185b4915b7bf..82425c9a623d 100644
> --- a/fs/xfs/xfs_error.c
> +++ b/fs/xfs/xfs_error.c
> @@ -299,6 +299,7 @@ xfs_errortag_add(
>  	struct xfs_mount	*mp,
>  	unsigned int		error_tag)
>  {
> +	BUILD_BUG_ON(ARRAY_SIZE(xfs_errortag_random_default) != XFS_ERRTAG_MAX);
>  	if (error_tag >= XFS_ERRTAG_MAX)
>  		return -EINVAL;
>  
> -- 
> 2.20.1
>
Christoph Hellwig March 11, 2021, 1 p.m. UTC | #2 
Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c
index 185b4915b7bf..82425c9a623d 100644
--- a/fs/xfs/xfs_error.c
+++ b/fs/xfs/xfs_error.c
@@ -299,6 +299,7 @@  xfs_errortag_add(
 	struct xfs_mount	*mp,
 	unsigned int		error_tag)
 {
+	BUILD_BUG_ON(ARRAY_SIZE(xfs_errortag_random_default) != XFS_ERRTAG_MAX);
 	if (error_tag >= XFS_ERRTAG_MAX)
 		return -EINVAL;