diff mbox series

[2/6] xfs/007: unmount after disabling quota

Message ID 20210712111146.82734-3-hch@lst.de (mailing list archive)
State Superseded
Headers show
Series [1/6] common/quota: allow removing quota options entirely in _qmount_option | expand

Commit Message

Christoph Hellwig July 12, 2021, 11:11 a.m. UTC
With the pending patches to remove support for disabling quota
accounting on a mounted file system we need to unmount the
file system first before removing the quota files.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 tests/xfs/007 | 3 +++
 1 file changed, 3 insertions(+)

Comments

Darrick J. Wong July 14, 2021, 11:35 p.m. UTC | #1
On Mon, Jul 12, 2021 at 01:11:42PM +0200, Christoph Hellwig wrote:
> With the pending patches to remove support for disabling quota
> accounting on a mounted file system we need to unmount the
> file system first before removing the quota files.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  tests/xfs/007 | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/xfs/007 b/tests/xfs/007
> index 09268e8c..d1946524 100755
> --- a/tests/xfs/007
> +++ b/tests/xfs/007
> @@ -41,6 +41,9 @@ do_test()
>  	_qmount
>  	echo "*** turn off $off_opts quotas"
>  	xfs_quota -x -c "off -$off_opts" $SCRATCH_MNT
> +	_scratch_unmount
> +	_qmount_option ""
> +	_scratch_mount
>  	xfs_quota -x -c "remove -$off_opts" $SCRATCH_MNT
>  	echo "*** umount"
>  	_scratch_unmount
> -- 
> 2.30.2
>
diff mbox series

Patch

diff --git a/tests/xfs/007 b/tests/xfs/007
index 09268e8c..d1946524 100755
--- a/tests/xfs/007
+++ b/tests/xfs/007
@@ -41,6 +41,9 @@  do_test()
 	_qmount
 	echo "*** turn off $off_opts quotas"
 	xfs_quota -x -c "off -$off_opts" $SCRATCH_MNT
+	_scratch_unmount
+	_qmount_option ""
+	_scratch_mount
 	xfs_quota -x -c "remove -$off_opts" $SCRATCH_MNT
 	echo "*** umount"
 	_scratch_unmount