| Message ID | 20220629235546.3843096-1-leah.rumancik@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [5.15] MAINTAINERS: add Leah as xfs maintainer for 5.15.y | expand |
On Wed, Jun 29, 2022 at 04:55:46PM -0700, Leah Rumancik wrote: > Update MAINTAINERS for xfs in an effort to help direct bots/questions > about xfs in 5.15.y. > > Note: 5.10.y [1] and 5.4.y will have different updates to their > respective MAINTAINERS files for this effort. > > Suggested-by: Darrick J. Wong <djwong@kernel.org> > Signed-off-by: Leah Rumancik <leah.rumancik@gmail.com> LGTM for 5.15 Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > > [1] https://lore.kernel.org/linux-xfs/20220629213236.495647-1-amir73il@gmail.com/ > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 393706e85ba2..a60d7e0466af 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -20579,6 +20579,7 @@ F: drivers/xen/*swiotlb* > > XFS FILESYSTEM > C: irc://irc.oftc.net/xfs > +M: Leah Rumancik <leah.rumancik@gmail.com> > M: Darrick J. Wong <djwong@kernel.org> > M: linux-xfs@vger.kernel.org > L: linux-xfs@vger.kernel.org > -- > 2.37.0.rc0.161.g10f37bed90-goog >
On Thu, Jun 30, 2022 at 3:11 AM Leah Rumancik <leah.rumancik@gmail.com> wrote: > > Update MAINTAINERS for xfs in an effort to help direct bots/questions > about xfs in 5.15.y. > > Note: 5.10.y [1] and 5.4.y will have different updates to their > respective MAINTAINERS files for this effort. > > Suggested-by: Darrick J. Wong <djwong@kernel.org> > Signed-off-by: Leah Rumancik <leah.rumancik@gmail.com> > > [1] https://lore.kernel.org/linux-xfs/20220629213236.495647-1-amir73il@gmail.com/ It is not good practice to put stuff after the commit message trailer. Greg's signature is going to be after that line. In this case, I think you could simply drop the [1] reference it's not important in git historic perspective. You could add the references after --- if you like. Thanks, Amir. > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 393706e85ba2..a60d7e0466af 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -20579,6 +20579,7 @@ F: drivers/xen/*swiotlb* > > XFS FILESYSTEM > C: irc://irc.oftc.net/xfs > +M: Leah Rumancik <leah.rumancik@gmail.com> > M: Darrick J. Wong <djwong@kernel.org> > M: linux-xfs@vger.kernel.org > L: linux-xfs@vger.kernel.org > -- > 2.37.0.rc0.161.g10f37bed90-goog >
On Thu, Jun 30, 2022 at 08:31:03AM +0300, Amir Goldstein wrote: > On Thu, Jun 30, 2022 at 3:11 AM Leah Rumancik <leah.rumancik@gmail.com> wrote: > > > > Update MAINTAINERS for xfs in an effort to help direct bots/questions > > about xfs in 5.15.y. > > > > Note: 5.10.y [1] and 5.4.y will have different updates to their > > respective MAINTAINERS files for this effort. > > > > Suggested-by: Darrick J. Wong <djwong@kernel.org> > > Signed-off-by: Leah Rumancik <leah.rumancik@gmail.com> > > > > [1] https://lore.kernel.org/linux-xfs/20220629213236.495647-1-amir73il@gmail.com/ > > It is not good practice to put stuff after the commit message trailer. > Greg's signature is going to be after that line. > In this case, I think you could simply drop the [1] reference > it's not important in git historic perspective. > > You could add the references after --- if you like. Sure, that makes sense. Thanks for pointing this out. - Leah > > Thanks, > Amir. > > > --- > > MAINTAINERS | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 393706e85ba2..a60d7e0466af 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -20579,6 +20579,7 @@ F: drivers/xen/*swiotlb* > > > > XFS FILESYSTEM > > C: irc://irc.oftc.net/xfs > > +M: Leah Rumancik <leah.rumancik@gmail.com> > > M: Darrick J. Wong <djwong@kernel.org> > > M: linux-xfs@vger.kernel.org > > L: linux-xfs@vger.kernel.org > > -- > > 2.37.0.rc0.161.g10f37bed90-goog > >
diff --git a/MAINTAINERS b/MAINTAINERS index 393706e85ba2..a60d7e0466af 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20579,6 +20579,7 @@ F: drivers/xen/*swiotlb* XFS FILESYSTEM C: irc://irc.oftc.net/xfs +M: Leah Rumancik <leah.rumancik@gmail.com> M: Darrick J. Wong <djwong@kernel.org> M: linux-xfs@vger.kernel.org L: linux-xfs@vger.kernel.org
Update MAINTAINERS for xfs in an effort to help direct bots/questions about xfs in 5.15.y. Note: 5.10.y [1] and 5.4.y will have different updates to their respective MAINTAINERS files for this effort. Suggested-by: Darrick J. Wong <djwong@kernel.org> Signed-off-by: Leah Rumancik <leah.rumancik@gmail.com> [1] https://lore.kernel.org/linux-xfs/20220629213236.495647-1-amir73il@gmail.com/ --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+)