| Message ID | 20220902073232.319601-1-ye.xingchen@zte.com.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [linux-next] xfs: Remove the unneeded result variable | expand |
On Fri, Sep 02, 2022 at 07:32:32AM +0000, cgel.zte@gmail.com wrote: > From: ye xingchen <ye.xingchen@zte.com.cn> > > Return the value xfs_dir_cilookup_result() directly instead of storing it > in another redundant variable. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> LGTM. Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > fs/xfs/libxfs/xfs_dir2_sf.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_dir2_sf.c b/fs/xfs/libxfs/xfs_dir2_sf.c > index 003812fd7d35..8cd37e6e9d38 100644 > --- a/fs/xfs/libxfs/xfs_dir2_sf.c > +++ b/fs/xfs/libxfs/xfs_dir2_sf.c > @@ -865,7 +865,6 @@ xfs_dir2_sf_lookup( > struct xfs_inode *dp = args->dp; > struct xfs_mount *mp = dp->i_mount; > int i; /* entry index */ > - int error; > xfs_dir2_sf_entry_t *sfep; /* shortform directory entry */ > xfs_dir2_sf_hdr_t *sfp; /* shortform structure */ > enum xfs_dacmp cmp; /* comparison result */ > @@ -929,8 +928,7 @@ xfs_dir2_sf_lookup( > if (!ci_sfep) > return -ENOENT; > /* otherwise process the CI match as required by the caller */ > - error = xfs_dir_cilookup_result(args, ci_sfep->name, ci_sfep->namelen); > - return error; > + return xfs_dir_cilookup_result(args, ci_sfep->name, ci_sfep->namelen); > } > > /* > -- > 2.25.1
diff --git a/fs/xfs/libxfs/xfs_dir2_sf.c b/fs/xfs/libxfs/xfs_dir2_sf.c index 003812fd7d35..8cd37e6e9d38 100644 --- a/fs/xfs/libxfs/xfs_dir2_sf.c +++ b/fs/xfs/libxfs/xfs_dir2_sf.c @@ -865,7 +865,6 @@ xfs_dir2_sf_lookup( struct xfs_inode *dp = args->dp; struct xfs_mount *mp = dp->i_mount; int i; /* entry index */ - int error; xfs_dir2_sf_entry_t *sfep; /* shortform directory entry */ xfs_dir2_sf_hdr_t *sfp; /* shortform structure */ enum xfs_dacmp cmp; /* comparison result */ @@ -929,8 +928,7 @@ xfs_dir2_sf_lookup( if (!ci_sfep) return -ENOENT; /* otherwise process the CI match as required by the caller */ - error = xfs_dir_cilookup_result(args, ci_sfep->name, ci_sfep->namelen); - return error; + return xfs_dir_cilookup_result(args, ci_sfep->name, ci_sfep->namelen); } /*