Message ID | 20230213040445.192946-25-chandan.babu@oracle.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show
Return-Path: <linux-xfs-owner@vger.kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7190BC636D7 for <linux-xfs@archiver.kernel.org>; Mon, 13 Feb 2023 04:08:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229554AbjBMEIb (ORCPT <rfc822;linux-xfs@archiver.kernel.org>); Sun, 12 Feb 2023 23:08:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjBMEIa (ORCPT <rfc822;linux-xfs@vger.kernel.org>); Sun, 12 Feb 2023 23:08:30 -0500 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E692AE044 for <linux-xfs@vger.kernel.org>; Sun, 12 Feb 2023 20:08:28 -0800 (PST) Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31D1hws4013421; Mon, 13 Feb 2023 04:08:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2022-7-12; bh=QXHChvJf6S1B1vkjlfBdI3n4LIWXm9pb4OEYHiw0koQ=; b=v4FaVZiJLkKo/CYZILpNCHcIA4WVv62IUOjYk7uvNU7NdrLAd//QmXxYT3COwPGHBveP Viea30ZonYQRhkUk6Md6owQAeB+D/+gkgod1BmhQyuWE2vhKjgCngJ6gwBxioWqe/Z1X Lb4kUIfBBqHEeCtYbu8QoQ7lAOHBRUVyzizXDH2l/v4cYlci5VqH/Xx7yilRyoBdGU63 902+yK6Gs/1SayoZxBM4hKTwUIwvhLkYNSWCAbffKSTy8sFq5ex6E3BW3X0T1rGF2i49 DGqBSPeKGnQVckauUW39Uz1uDtOiwpZos0KARDM+Qw+yfi9xfXIYyVb21EKSawoyOd++ xA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3np32c9uku-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Feb 2023 04:08:25 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 31D3SK36028770; Mon, 13 Feb 2023 04:08:25 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3np1f3jyt9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Feb 2023 04:08:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nmeX71f7MfsCWGQgYnRs47TTxNt6eDIJ6MbDUUgzzNXrWsWtFhwSBu9OKvWEX5Rdwo1EiTLov6TVeUdEyuNQYXuhJtcfRiCFsRuEjph8jHbVorxTDb9Ned86z6Qpl8E2+szvlewo773rWLhWkg1+Rd13y2saQWXlB0OsdUj6T8gkE16D1MWugdr+55UyxUpMIkQqcoOfcNAUrDYuMGUQaBZtngZGpqlpv/8f1ZpmvMrvmsghQFqfkcSGJ0+Uj3ETFsOc3Vr+s4JMmHgQnbue2SECOTeNYIlkjSWFafTMaKyBgQBgOKT+cVvqjTsgE+7Xhdj69tOyhVMuwDrE6TS9fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QXHChvJf6S1B1vkjlfBdI3n4LIWXm9pb4OEYHiw0koQ=; b=UuR4vGzLHkx/cBJQCnp9KtqnMVd19rbDdo6v5e/JR5Za81VfMpteNhy8l283rZFs+LcLOjZT20HWkcSjqh/k15Y7qGWa8zk/oV7kLHeD7UxskmY+3qpPjeOCY6b0uGHMCudfinz1Iclr73Z+HwamJYqaCWRZGjqd5apOmFAAn1kPUcXo+X1BVfaI17pYsv9kjL7+PlvwL8vS40j/48xHVydPntyvn2PqG67ahxkz3D56dqRWBkaFuNWYI2MJFWGUIZ+0BtDI5EE+6Pjzkt+hYQSf9bni8B1vZfbz77doXsuUSX72LJIAa01GN/G10UIIHD25k/RRPnCuKZFVy+/nyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QXHChvJf6S1B1vkjlfBdI3n4LIWXm9pb4OEYHiw0koQ=; b=zhauJ6hORecFT61JQ9DDaTD5YaIoY21OO39Di2+qDQITp2rv+XfqAREIWuGTLz7TsC4AyE/Uz7s8AA0a/i+veF4cGaF78oKcqMarpEAV04OjV1XSCfr/DMScr5PAi2J57Pb4FEWXZVPLFXRqm6SK58cB3soccDcaMCqWHAIAKLk= Received: from SA1PR10MB5867.namprd10.prod.outlook.com (2603:10b6:806:22b::9) by BL3PR10MB6089.namprd10.prod.outlook.com (2603:10b6:208:3b5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.8; Mon, 13 Feb 2023 04:08:17 +0000 Received: from SA1PR10MB5867.namprd10.prod.outlook.com ([fe80::6d82:720d:3596:839c]) by SA1PR10MB5867.namprd10.prod.outlook.com ([fe80::6d82:720d:3596:839c%3]) with mapi id 15.20.6111.009; Mon, 13 Feb 2023 04:08:17 +0000 From: Chandan Babu R <chandan.babu@oracle.com> To: djwong@kernel.org Cc: chandan.babu@oracle.com, linux-xfs@vger.kernel.org, amir73il@gmail.com, leah.rumancik@gmail.com Subject: [PATCH 5.4 CANDIDATE 24/25] xfs: prevent UAF in xfs_log_item_in_current_chkpt Date: Mon, 13 Feb 2023 09:34:44 +0530 Message-Id: <20230213040445.192946-25-chandan.babu@oracle.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230213040445.192946-1-chandan.babu@oracle.com> References: <20230213040445.192946-1-chandan.babu@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: TYWP286CA0028.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:262::14) To SA1PR10MB5867.namprd10.prod.outlook.com (2603:10b6:806:22b::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR10MB5867:EE_|BL3PR10MB6089:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b4949e2-42cd-4bab-6441-08db0d77efaa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OORa2cKYPlTvjeyPnntCfayDqzhQ7iJc32zZiLXQUwQBewk/H+gzjlE2/AkPGlVIcJC2GlUDI1/YbYTHiDiRepoGW7KXWsJGiNJ2i77brukAUGaibYnddYuZLdfo6ZFJXludSc7RZcfgZLQJM/t7W4/n00JkYsNZDMdWLGvsqaPKlp58FPqKrPDyQnCuMLcPt8kb+TNuIkvOvn0MJxRVKHEhY7m7B0jiJBTtNcN3Bt0jkOmpFOo1H3mvu2WlBrsHgtU6EeOZ8ocwGWQjnlm92r7yVaANW2q6bs3THRzeBsdWJTpJRcRZ0DNdzxF8uJAdYg4R1GZpHPsAjHQ8By8qVfY3IJbK+PhBrLysO5h1yFatjHNbwaxXuXCBMC5EjDSBK17y2BQJ70thx7echqvV7w+0UKlSwhHYTDGynt8WvQSjFE88AVzYe4rSsvX7MqiYxnkySVB4U1JH0cZaAwkgnC5+nz+WsyPVKsN9vv+stsoLqG24/BIVVGR1OqanG/xjBY8I9lRuGhwsEQQSznVrmJQJmGJrVJ6MBawzrW8Z7+oEKulSs+cS2xUzCkSTYKpD6eUth0CbzjGBMkar+AjSVgHvUAQfdTvLOHATXlyC6tUNZQy2HUsg09+02NfPCXllpTCLJExcZTbtkZOglZsgag== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR10MB5867.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(346002)(136003)(366004)(39860400002)(396003)(451199018)(86362001)(36756003)(38100700002)(316002)(8676002)(4326008)(8936002)(66476007)(5660300002)(41300700001)(66946007)(6916009)(66556008)(2906002)(2616005)(83380400001)(478600001)(6486002)(186003)(26005)(6666004)(6506007)(1076003)(6512007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Ggb21CSR5/jiDqA9xS02cjhf0WUFhDRr2750+KpDJH4XfQss2Qia7/M/2oddzQKz88pbRjimwQQfRdnnAq5T7yaiXV8yZ1S9aS7CHMzaYSmsJ3wYdwYt39z7yQjcKG10y/+M6xEGwN1njcXqX6ZbsZgUsCYDD/DbdQTWHtR4IsLB8nYLF6XWS8oBTZ44LPM60ICglHTAcYpRfOfmhRh9Wi2TMRDhcEHtCYXU049us9oKRaK6Sg+2rq0NoI4/gvpTP5pmjHp76lnx3C8ELWehISML1t9PCEi9wtyBQ+mdZ5+wEzhM4oiTCT6PoCVAPSHIFHp7Jj7m6YM94jR/A8JR4YD3/5LZe1V0G++EJIQc1XlA97gBpbFRq6G3FqolZzx/shm0I4kwT7QbQsQCe1aP59U12v7DVoe/MO7dMIPoP3nbbDWJ26alsChkTtJIFVV0oL03C9qTeKDu7/Wrsbr9/WqGLjYVfkAxJdL/bP4Aw0U9md+vdfApQZOATAobxtMn2ArPKJTsJCOZNYjDJ1Wwdq9xgHge1vBLzRNb6DtUSNGX5UFioeW4mBgkYM5lY2xoyPjcJigbJzaTNJPB0s5IzmBnSsjmybwQ9D3YmaUAXNZSjjsanSA9mVWeecyW9+oUYaNpFJWNWySN64vJEzGK4SFpJjfeAZpjsKKGbtU5gt9/5IWkkTX9en6fMhI7jE1acFrPEdzx2pHfEKFAUudM93MF7ZSTEweGXdc8koLLYQ/nZR1bFdmOY76utKBfwcwhkr3VGrsD8LQgx4RDCgTBEkxeS/hPRdJkmix3gLlXQo26mEdgmoZllQ9PcoLdDXYC4I1UeBG1wyagTh2n8xEz+ltSBq1ATE/JkZKHhfMqi7+A3KK0CaqfeTQoSv/IYk4Bg9alOESJ/fgSjjbAROgXTjTgE2h/IyCbQuFckZzJmigkvr/1XbsAlP5hGWhOMrG+yd01EKNWT1LTrD+n9htRLCAz/wk3dH2HhCu/jRUxKmjza+ij7pYqF2KwfwsEAgNhaO2/y4I18lzu+8onoA0R3q9PeLDPRdPNzWn/6xji4GG4mHfRAVQFA+dyd3C1YRPCmm+tp8m4Rz2yhK4c+0rGQMoN1+keM0ui435j0G+uarHf+sW8vuZqgJDdKWekEacg6ac6/UUMXXs8Kr+3AbdcfcW8ICuwuqlsm7jO3U+ac/hVe6drfYwEc6h3T1Ix5+uTaa2Gr2Etj1y5KNH36PJd4UotvaOz/nvPtMDshxkmc41ep+XpIjYcTiUqzB7avNdmhvz6WAfCCLQbM6v+UYuU3TPlOiBpXFMlobbt4TdhesaKSCKK2fh096x80ySdtBh1IaDWfCrzL0E+S6jATKda2HdKxBEGS2rsviImY5qaKCS056uBpGB0Q7l7ZSZ4AnY2k7EnM8g+nDwAO8gwDxRZVmjtRvNW/8jHRCHvzGJeaf6pnkQwuUowA7nPlImANBg21CFsUO/UGE4ciZH0P5LG5gBBCTJzFIkM+pY6K21pR0vdpEa+eNBeAnBGsXcx9Wb3TbioZWh5DGmn0MJ9lnTC9D9W7dlQHSzhB0ArKF13GNqVWoYlBbsrLvHSn9pksBPrDf9nhEcbRYmmBnbOmiIBlQ== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Q56F2q9H3HHdZKNzwrNHy98fB5/s7KyKXxIebFR23UfLgDyqGXWqTsKakEYQ8C/FpQSZBnCGozvvxsxfkb87jyAV0aZJuGJSH2osPItpyzzOcoTJHnJ8iJhKmhWuwjcyGNiXNK8n1RcpUoTqC43bov6uIloXNsUGZorBNdabQJXVEzcvMcHOlizMXwg1LkOnAVd/UV96xqek0xOvU8xFhLNXP0BHhTGCwTOBmW2aBe8JpEjK+r68DWqAvWdUaNRV0wxuKmJ+a7YvhnXuLvEiLdWRqpkp33Y+y1KslD/XePepHGQiQ9q0Njq0mNEjRdzI4FlIw7MO9KAB4ihPO/qgZ9UHDszugAVRkXMtGEpRKD0A5xRqdTzzrf86/z1GklSQ3KD+hllnhfWI+sfOCN/iJsWkjHbxVHhG5X0zvBChW4Z4UXaD14T8H3qSdNygcqtiAT27550vEWWZdkNXojTpllP3pBo19Gl3hFTr2fjanMflN/OilN6/7/ARN8WuPqhJtCyZMN1eqigjsQZ+1IvjW6HJx1FdEZFnpqt+iz10+v90XWHxi5/vIyUZcnLkWmf0ANp6CK3wLCGK095845a6Mh5+7ErJBpT9l9ZcUf/TwavBo5psMp2BRvPsZwYnMxWgDSsmyQcngtbPZnw40Pra7i5AaFL3DE8vCGI1l2FjSOGkgZRFC1dfePVgorz2Iwd5M46KWJ5vFJPAg+FdHo9uNCXe4j8DRrQGciyzKvkjd6GWSFQArV7tlrdatpMPAN3Upolmy0c7DHtoI8LP0TBxk9WjMeKLk+fxYGSwbKgwT4XkVUkcuAPx2SV4N+IRhyxI X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b4949e2-42cd-4bab-6441-08db0d77efaa X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB5867.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 04:08:17.8434 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VwPjLjhf38sYPpVYMXcSOYmhKDzDhb8WoaX6MS8N1WejHGZKBeK3zYuRcknleKqTdTwWeqMKatTVx82SJN6IPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR10MB6089 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-13_01,2023-02-09_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 adultscore=0 mlxlogscore=999 phishscore=0 spamscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302130037 X-Proofpoint-GUID: U9Wm_PoEoOcLfBFqGiYi9xJ1JQWZxRL8 X-Proofpoint-ORIG-GUID: U9Wm_PoEoOcLfBFqGiYi9xJ1JQWZxRL8 Precedence: bulk List-ID: <linux-xfs.vger.kernel.org> X-Mailing-List: linux-xfs@vger.kernel.org |
Series |
xfs stable candidate patches for 5.4.y (from v5.10)
|
expand
|
diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c index 550fd5de2404..ae9b8efcfa54 100644 --- a/fs/xfs/xfs_log_cil.c +++ b/fs/xfs/xfs_log_cil.c @@ -1178,21 +1178,19 @@ xlog_cil_force_lsn( */ bool xfs_log_item_in_current_chkpt( - struct xfs_log_item *lip) + struct xfs_log_item *lip) { - struct xfs_cil_ctx *ctx; + struct xfs_cil *cil = lip->li_mountp->m_log->l_cilp; if (list_empty(&lip->li_cil)) return false; - ctx = lip->li_mountp->m_log->l_cilp->xc_ctx; - /* * li_seq is written on the first commit of a log item to record the * first checkpoint it is written to. Hence if it is different to the * current sequence, we're in a new checkpoint. */ - if (XFS_LSN_CMP(lip->li_seq, ctx->sequence) != 0) + if (XFS_LSN_CMP(lip->li_seq, READ_ONCE(cil->xc_current_sequence)) != 0) return false; return true; }