diff mbox series

[14/24] xfs_metadump.sh: Add support for passing version option

Message ID 20230523090050.373545-15-chandan.babu@oracle.com (mailing list archive)
State New, archived
Headers show
Series Metadump v2 | expand

Commit Message

Chandan Babu R May 23, 2023, 9 a.m. UTC 
The new option allows the user to explicitly specify which version of
metadump to use. However, we will default to using the v1 format.
---
 db/xfs_metadump.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Darrick J. Wong May 23, 2023, 5:39 p.m. UTC | #1 
On Tue, May 23, 2023 at 02:30:40PM +0530, Chandan Babu R wrote:
> The new option allows the user to explicitly specify which version of
> metadump to use. However, we will default to using the v1 format.

Needs SOB tag.

--D

> ---
>  db/xfs_metadump.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/db/xfs_metadump.sh b/db/xfs_metadump.sh
> index 9852a5bc2..9e8f86e53 100755
> --- a/db/xfs_metadump.sh
> +++ b/db/xfs_metadump.sh
> @@ -8,7 +8,7 @@ OPTS=" "
>  DBOPTS=" "
>  USAGE="Usage: xfs_metadump [-aefFogwV] [-m max_extents] [-l logdev] source target"
>  
> -while getopts "aefgl:m:owFV" c
> +while getopts "aefgl:m:owFv:V" c
>  do
>  	case $c in
>  	a)	OPTS=$OPTS"-a ";;
> @@ -20,6 +20,7 @@ do
>  	f)	DBOPTS=$DBOPTS" -f";;
>  	l)	DBOPTS=$DBOPTS" -l "$OPTARG" ";;
>  	F)	DBOPTS=$DBOPTS" -F";;
> +	v)	OPTS=$OPTS"-v "$OPTARG" ";;
>  	V)	xfs_db -p xfs_metadump -V
>  		status=$?
>  		exit $status
> -- 
> 2.39.1
>
Chandan Babu R May 25, 2023, 9:31 a.m. UTC | #2 
On Tue, May 23, 2023 at 10:39:30 AM -0700, Darrick J. Wong wrote:
> On Tue, May 23, 2023 at 02:30:40PM +0530, Chandan Babu R wrote:
>> The new option allows the user to explicitly specify which version of
>> metadump to use. However, we will default to using the v1 format.
>
> Needs SOB tag.

I will add my SOB tag and resend the patchset.
diff mbox series

Patch

diff --git a/db/xfs_metadump.sh b/db/xfs_metadump.sh
index 9852a5bc2..9e8f86e53 100755
--- a/db/xfs_metadump.sh
+++ b/db/xfs_metadump.sh
@@ -8,7 +8,7 @@  OPTS=" "
 DBOPTS=" "
 USAGE="Usage: xfs_metadump [-aefFogwV] [-m max_extents] [-l logdev] source target"
 
-while getopts "aefgl:m:owFV" c
+while getopts "aefgl:m:owFv:V" c
 do
 	case $c in
 	a)	OPTS=$OPTS"-a ";;
@@ -20,6 +20,7 @@  do
 	f)	DBOPTS=$DBOPTS" -f";;
 	l)	DBOPTS=$DBOPTS" -l "$OPTARG" ";;
 	F)	DBOPTS=$DBOPTS" -F";;
+	v)	OPTS=$OPTS"-v "$OPTARG" ";;
 	V)	xfs_db -p xfs_metadump -V
 		status=$?
 		exit $status