| Message ID | 20230621105520.17560-1-polynomial-c@gmx.de (mailing list archive) |
|---|---|
| State | Deferred, archived |
| Headers | show |
| Series | po/de.po: Fix possible typo which makes gettext-0.22 unhappy | expand |
On 2023-06-21 12:55, Lars Wendler wrote: > diff --git a/po/de.po b/po/de.po > index 944b0e91..a6f8fde1 100644 > --- a/po/de.po > +++ b/po/de.po > @@ -3084,7 +3084,7 @@ msgstr "%llu Spezialdateien\n" > #: .././estimate/xfs_estimate.c:191 > #, c-format > msgid "%s will take about %.1f megabytes\n" > -msgstr "%s wird etwa %.lf Megabytes einnehmen\n" > +msgstr "%s wird etwa %.1f Megabytes einnehmen\n" I don't see the difference..? Both the added and removed line are the same. -h
Am Wed, 21 Jun 2023 13:29:03 +0200 schrieb Holger Hoffstätte <holger@applied-asynchrony.com>: > On 2023-06-21 12:55, Lars Wendler wrote: > > diff --git a/po/de.po b/po/de.po > > index 944b0e91..a6f8fde1 100644 > > --- a/po/de.po > > +++ b/po/de.po > > @@ -3084,7 +3084,7 @@ msgstr "%llu Spezialdateien\n" > > #: .././estimate/xfs_estimate.c:191 > > #, c-format > > msgid "%s will take about %.1f megabytes\n" > > -msgstr "%s wird etwa %.lf Megabytes einnehmen\n" > > +msgstr "%s wird etwa %.1f Megabytes einnehmen\n" > > I don't see the difference..? > Both the added and removed line are the same. > > -h I suppose depending on the font, it's quite hard to distinguish the two lines. The removed line contains "%.lf" with a lowercase letter L. The added line contains "%.1f" where the lowercase letter L was replaced with the digit 1. Cheers Lars
On 2023-06-21 13:56, Lars Wendler wrote: > Am Wed, 21 Jun 2023 13:29:03 +0200 > schrieb Holger Hoffstätte <holger@applied-asynchrony.com>: > >> On 2023-06-21 12:55, Lars Wendler wrote: >>> diff --git a/po/de.po b/po/de.po >>> index 944b0e91..a6f8fde1 100644 >>> --- a/po/de.po >>> +++ b/po/de.po >>> @@ -3084,7 +3084,7 @@ msgstr "%llu Spezialdateien\n" >>> #: .././estimate/xfs_estimate.c:191 >>> #, c-format >>> msgid "%s will take about %.1f megabytes\n" >>> -msgstr "%s wird etwa %.lf Megabytes einnehmen\n" >>> +msgstr "%s wird etwa %.1f Megabytes einnehmen\n" >> >> I don't see the difference..? >> Both the added and removed line are the same. >> >> -h > > I suppose depending on the font, it's quite hard to distinguish the two > lines. > The removed line contains "%.lf" with a lowercase letter L. > The added line contains "%.1f" where the lowercase letter L was replaced > with the digit 1. Ahh..of course! Zooming in did the trick, I see the difference now. Thanks! -h
On Wed, Jun 21, 2023 at 01:56:08PM +0200, Lars Wendler wrote: > Am Wed, 21 Jun 2023 13:29:03 +0200 > schrieb Holger Hoffstätte <holger@applied-asynchrony.com>: > > > On 2023-06-21 12:55, Lars Wendler wrote: > > > diff --git a/po/de.po b/po/de.po > > > index 944b0e91..a6f8fde1 100644 > > > --- a/po/de.po > > > +++ b/po/de.po > > > @@ -3084,7 +3084,7 @@ msgstr "%llu Spezialdateien\n" > > > #: .././estimate/xfs_estimate.c:191 > > > #, c-format > > > msgid "%s will take about %.1f megabytes\n" > > > -msgstr "%s wird etwa %.lf Megabytes einnehmen\n" > > > +msgstr "%s wird etwa %.1f Megabytes einnehmen\n" > > > > I don't see the difference..? > > Both the added and removed line are the same. > > > > -h > > I suppose depending on the font, it's quite hard to distinguish the two > lines. I didn't see it, and the commit message doesn't explain anything, either. Pointing to a bugzilla somewhere does not make a valid commit message.... > The removed line contains "%.lf" with a lowercase letter L. > The added line contains "%.1f" where the lowercase letter L was replaced > with the digit 1. ... whereas this explains what the bug being fixed is, and allows the reviewer to see the subtle change being made. i.e. you just wrote the commit message that should have been in the patch in the first place. :) Can you please resend the fix with the commit message updated? Cheers, Dave.
diff --git a/po/de.po b/po/de.po index 944b0e91..a6f8fde1 100644 --- a/po/de.po +++ b/po/de.po @@ -3084,7 +3084,7 @@ msgstr "%llu Spezialdateien\n" #: .././estimate/xfs_estimate.c:191 #, c-format msgid "%s will take about %.1f megabytes\n" -msgstr "%s wird etwa %.lf Megabytes einnehmen\n" +msgstr "%s wird etwa %.1f Megabytes einnehmen\n" #: .././estimate/xfs_estimate.c:198 #, c-format
See downstream bug report: https://bugs.gentoo.org/908864 Signed-off-by: Lars Wendler <polynomial-c@gmx.de> --- po/de.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.41.0