| Message ID | 20230918142604.390357-1-cem@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mkfs: Update agsize description in the man page | expand |
On Mon, Sep 18, 2023 at 04:26:04PM +0200, cem@kernel.org wrote: > From: Carlos Maiolino <cem@kernel.org> > > agsize value accept different suffixes, including filesystem blocks, so, > replace "expressed in bytes" by "expressed as a multiple of filesystem > blocks". > > Suggested-by: Dave Chinner <david@fromorbit.com> > Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com> Reviewed-by: Bill O'Donnell <bodonnel@redhat.com> > --- > man/man8/mkfs.xfs.8.in | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/man/man8/mkfs.xfs.8.in b/man/man8/mkfs.xfs.8.in > index 08bb92f65..96c07fc71 100644 > --- a/man/man8/mkfs.xfs.8.in > +++ b/man/man8/mkfs.xfs.8.in > @@ -352,12 +352,11 @@ This is an alternative to using the > .B agcount > suboption. The > .I value > -is the desired size of the allocation group expressed in bytes > -(usually using the > +is the desired size of the allocation group expressed as a multiple of the > +filesystem block size (usually using the > .BR m " or " g > suffixes). > -This value must be a multiple of the filesystem block size, and > -must be at least 16MiB, and no more than 1TiB, and may > +It must be at least 16MiB, and no more than 1TiB, and may > be automatically adjusted to properly align with the stripe geometry. > The > .B agcount > -- > 2.39.2 >
On Mon, Sep 18, 2023 at 04:26:04PM +0200, cem@kernel.org wrote: > From: Carlos Maiolino <cem@kernel.org> > > agsize value accept different suffixes, including filesystem blocks, so, > replace "expressed in bytes" by "expressed as a multiple of filesystem > blocks". > > Suggested-by: Dave Chinner <david@fromorbit.com> > Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com> LGTM Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > man/man8/mkfs.xfs.8.in | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/man/man8/mkfs.xfs.8.in b/man/man8/mkfs.xfs.8.in > index 08bb92f65..96c07fc71 100644 > --- a/man/man8/mkfs.xfs.8.in > +++ b/man/man8/mkfs.xfs.8.in > @@ -352,12 +352,11 @@ This is an alternative to using the > .B agcount > suboption. The > .I value > -is the desired size of the allocation group expressed in bytes > -(usually using the > +is the desired size of the allocation group expressed as a multiple of the > +filesystem block size (usually using the > .BR m " or " g > suffixes). > -This value must be a multiple of the filesystem block size, and > -must be at least 16MiB, and no more than 1TiB, and may > +It must be at least 16MiB, and no more than 1TiB, and may > be automatically adjusted to properly align with the stripe geometry. > The > .B agcount > -- > 2.39.2 >
diff --git a/man/man8/mkfs.xfs.8.in b/man/man8/mkfs.xfs.8.in index 08bb92f65..96c07fc71 100644 --- a/man/man8/mkfs.xfs.8.in +++ b/man/man8/mkfs.xfs.8.in @@ -352,12 +352,11 @@ This is an alternative to using the .B agcount suboption. The .I value -is the desired size of the allocation group expressed in bytes -(usually using the +is the desired size of the allocation group expressed as a multiple of the +filesystem block size (usually using the .BR m " or " g suffixes). -This value must be a multiple of the filesystem block size, and -must be at least 16MiB, and no more than 1TiB, and may +It must be at least 16MiB, and no more than 1TiB, and may be automatically adjusted to properly align with the stripe geometry. The .B agcount