| Message ID | 20231105192318.121783-1-ailiop@suse.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | xfs: fix again select in kconfig XFS_ONLINE_SCRUB_STATS | expand |
On Sun, Nov 05, 2023 at 08:23:18PM +0100, Anthony Iliopoulos wrote: > Commit 57c0f4a8ea3a attempted to fix the select in the kconfig entry > XFS_ONLINE_SCRUB_STATS by selecting XFS_DEBUG, but the original > intention was to select DEBUG_FS, since the feature relies on debugfs to > export the related scrub statistics. > > Fixes: 57c0f4a8ea3a ("xfs: fix select in config XFS_ONLINE_SCRUB_STATS") > > Reported-by: Holger Hoffstätte <holger@applied-asynchrony.com> > Signed-off-by: Anthony Iliopoulos <ailiop@suse.com> Please add cc: <stable@kernel.org> so that it gets picked up for the 6.6 stable kernel. Otherwise, looks fine. Reviewed-by: Dave Chinner <dchinner@redhat.com>
On Sun, Nov 05, 2023 at 08:23:18PM +0100, Anthony Iliopoulos wrote: > Commit 57c0f4a8ea3a attempted to fix the select in the kconfig entry > XFS_ONLINE_SCRUB_STATS by selecting XFS_DEBUG, but the original > intention was to select DEBUG_FS, since the feature relies on debugfs to > export the related scrub statistics. > > Fixes: 57c0f4a8ea3a ("xfs: fix select in config XFS_ONLINE_SCRUB_STATS") > > Reported-by: Holger Hoffstätte <holger@applied-asynchrony.com> > Signed-off-by: Anthony Iliopoulos <ailiop@suse.com> Yep. Sorry about that garbledygook. Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > fs/xfs/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig > index ed0bc8cbc703..567fb37274d3 100644 > --- a/fs/xfs/Kconfig > +++ b/fs/xfs/Kconfig > @@ -147,7 +147,7 @@ config XFS_ONLINE_SCRUB_STATS > bool "XFS online metadata check usage data collection" > default y > depends on XFS_ONLINE_SCRUB > - select XFS_DEBUG > + select DEBUG_FS > help > If you say Y here, the kernel will gather usage data about > the online metadata check subsystem. This includes the number > -- > 2.42.0 >
diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig index ed0bc8cbc703..567fb37274d3 100644 --- a/fs/xfs/Kconfig +++ b/fs/xfs/Kconfig @@ -147,7 +147,7 @@ config XFS_ONLINE_SCRUB_STATS bool "XFS online metadata check usage data collection" default y depends on XFS_ONLINE_SCRUB - select XFS_DEBUG + select DEBUG_FS help If you say Y here, the kernel will gather usage data about the online metadata check subsystem. This includes the number
Commit 57c0f4a8ea3a attempted to fix the select in the kconfig entry XFS_ONLINE_SCRUB_STATS by selecting XFS_DEBUG, but the original intention was to select DEBUG_FS, since the feature relies on debugfs to export the related scrub statistics. Fixes: 57c0f4a8ea3a ("xfs: fix select in config XFS_ONLINE_SCRUB_STATS") Reported-by: Holger Hoffstätte <holger@applied-asynchrony.com> Signed-off-by: Anthony Iliopoulos <ailiop@suse.com> --- fs/xfs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)