| Message ID | 20240112044743.2254211-2-hch@lst.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/4] libxfs: remove the unused fs_topology_t typedef | expand |
On Fri, Jan 12, 2024 at 05:47:40AM +0100, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > libxfs/topology.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libxfs/topology.h b/libxfs/topology.h > index 1af5b0549..3a309a4da 100644 > --- a/libxfs/topology.h > +++ b/libxfs/topology.h > @@ -10,13 +10,13 @@ > /* > * Device topology information. > */ > -typedef struct fs_topology { > +struct fs_topology { > int dsunit; /* stripe unit - data subvolume */ > int dswidth; /* stripe width - data subvolume */ > int rtswidth; /* stripe width - rt subvolume */ > int lsectorsize; /* logical sector size &*/ Dumb nit: the ampersand in the comment can go away too ^ Don't much care either way though. Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > int psectorsize; /* physical sector size */ > -} fs_topology_t; > +}; > > void > get_topology( > -- > 2.39.2 > >
On Fri, Jan 12, 2024 at 08:44:50AM -0800, Darrick J. Wong wrote:
> Dumb nit: the ampersand in the comment can go away too ^
It'll go away in the next patch.
On Fri, Jan 12, 2024 at 05:48:17PM +0100, Christoph Hellwig wrote: > On Fri, Jan 12, 2024 at 08:44:50AM -0800, Darrick J. Wong wrote: > > Dumb nit: the ampersand in the comment can go away too ^ > > It'll go away in the next patch. Ahah so it does. I withdraw the comment, but maintain the RVB. --D
diff --git a/libxfs/topology.h b/libxfs/topology.h index 1af5b0549..3a309a4da 100644 --- a/libxfs/topology.h +++ b/libxfs/topology.h @@ -10,13 +10,13 @@ /* * Device topology information. */ -typedef struct fs_topology { +struct fs_topology { int dsunit; /* stripe unit - data subvolume */ int dswidth; /* stripe width - data subvolume */ int rtswidth; /* stripe width - rt subvolume */ int lsectorsize; /* logical sector size &*/ int psectorsize; /* physical sector size */ -} fs_topology_t; +}; void get_topology(
Signed-off-by: Christoph Hellwig <hch@lst.de> --- libxfs/topology.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)