[25/27] configure: don't check for fstatat

Message ID	20240129073215.108519-26-hch@lst.de (mailing list archive)
State	Superseded
Headers	show Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AC744F1E7 for <linux-xfs@vger.kernel.org>; Mon, 29 Jan 2024 07:33:24 +0000 (UTC) From: Christoph Hellwig <hch@lst.de> To: cem@kernel.org Cc: linux-xfs@vger.kernel.org Subject: [PATCH 25/27] configure: don't check for fstatat Date: Mon, 29 Jan 2024 08:32:13 +0100 Message-Id: <20240129073215.108519-26-hch@lst.de> In-Reply-To: <20240129073215.108519-1-hch@lst.de> References: <20240129073215.108519-1-hch@lst.de> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	[01/27] include: remove the filldir_t typedef \| expand [01/27] include: remove the filldir_t typedef [02/27] include: unconditionally define umode_t [03/27] repair: refactor the BLKMAP_NEXTS_MAX check [04/27] include: stop using SIZEOF_LONG [05/27] include: stop generating platform_defs.h [06/27] io: don't redefine SEEK_DATA and SEEK_HOLE [07/27] configure: don't check for getmntent [08/27] configure: require libblkid [09/27] configure: don't check for fadvise [10/27] configure: don't check for sendfile [11/27] configure: don't check for madvise [12/27] configure: don't check for mincor [13/27] configure: don't check for fiemap [14/27] configure: don't check for sync_file_range [15/27] configure: don't check for readdir [16/27] configure: don't check for fls [17/27] configure: don't check for fallocate [18/27] configure: don't check for syncfs [19/27] configure: don't check for preadv and pwritev [20/27] configure: don't check for mremap [21/27] configure: don't check for fsetxattr [22/27] configure: don't check for the f_flags field in statfs [23/27] configure: don't check for mallinfo [24/27] configure: don't check for openat [25/27] configure: don't check for fstatat [26/27] configure: don't check for SG_IO [27/27] configure: don't check for HDIO_GETGEO

Message ID

20240129073215.108519-26-hch@lst.de (mailing list archive)

State

Superseded

Headers

From: Christoph Hellwig <hch@lst.de>
To: cem@kernel.org
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 25/27] configure: don't check for fstatat
Date: Mon, 29 Jan 2024 08:32:13 +0100
Message-Id: <20240129073215.108519-26-hch@lst.de>
In-Reply-To: <20240129073215.108519-1-hch@lst.de>
References: <20240129073215.108519-1-hch@lst.de>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

[01/27] include: remove the filldir_t typedef | expand

Commit Message

Christoph Hellwig Jan. 29, 2024, 7:32 a.m. UTC

fstatat has been supported since Linux 2.6.16 and glibc 2.4.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 configure.ac          |  1 -
 include/builddefs.in  |  1 -
 m4/package_libcdev.m4 | 14 --------------
 scrub/Makefile        |  4 ++--
 4 files changed, 2 insertions(+), 18 deletions(-)

diff --git a/configure.ac b/configure.ac
index 47531fce5..260772a6b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -181,7 +181,6 @@  if test "$enable_scrub" = "yes"; then
                 AC_MSG_ERROR([libicu not found.])
         fi
 fi
-AC_HAVE_FSTATAT
 AC_HAVE_SG_IO
 AC_HAVE_HDIO_GETGEO
 AC_CONFIG_SYSTEMD_SYSTEM_UNIT_DIR
diff --git a/include/builddefs.in b/include/builddefs.in
index c768d0411..e02600f09 100644
--- a/include/builddefs.in
+++ b/include/builddefs.in
@@ -101,7 +101,6 @@  HAVE_DEVMAPPER = @have_devmapper@
 HAVE_MALLINFO2 = @have_mallinfo2@
 HAVE_LIBATTR = @have_libattr@
 HAVE_LIBICU = @have_libicu@
-HAVE_FSTATAT = @have_fstatat@
 HAVE_SG_IO = @have_sg_io@
 HAVE_HDIO_GETGEO = @have_hdio_getgeo@
 HAVE_SYSTEMD = @have_systemd@
diff --git a/m4/package_libcdev.m4 b/m4/package_libcdev.m4
index f857bcd94..0ff05a04b 100644
--- a/m4/package_libcdev.m4
+++ b/m4/package_libcdev.m4
@@ -157,20 +157,6 @@  test = mallinfo2();
     AC_SUBST(have_mallinfo2)
   ])
 
-#
-# Check if we have a fstatat call
-#
-AC_DEFUN([AC_HAVE_FSTATAT],
-  [ AC_CHECK_DECL([fstatat],
-       have_fstatat=yes,
-       [],
-       [#define _GNU_SOURCE
-       #include <sys/types.h>
-       #include <sys/stat.h>
-       #include <unistd.h>])
-    AC_SUBST(have_fstatat)
-  ])
-
 #
 # Check if we have the SG_IO ioctl
 #
diff --git a/scrub/Makefile b/scrub/Makefile
index 1d613b946..4eac20a13 100644
--- a/scrub/Makefile
+++ b/scrub/Makefile
@@ -6,11 +6,11 @@  TOPDIR = ..
 builddefs=$(TOPDIR)/include/builddefs
 include $(builddefs)
 
-SCRUB_PREREQS=$(HAVE_FSTATAT)$(HAVE_GETFSMAP)
+SCRUB_PREREQS=$(HAVE_GETFSMAP)
 
 scrub_svcname=xfs_scrub@.service
 
-ifeq ($(SCRUB_PREREQS),yesyes)
+ifeq ($(SCRUB_PREREQS),yes)
 LTCOMMAND = xfs_scrub
 INSTALL_SCRUB = install-scrub
 XFS_SCRUB_ALL_PROG = xfs_scrub_all

[25/27] configure: don't check for fstatat

Commit Message

Patch