Message ID | 20240208232054.15778-16-catherine.hoang@oracle.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show
Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EF6C54BE1; Thu, 8 Feb 2024 23:21:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707434494; cv=fail; b=Gmj/W4u6VsUfyHeYAiBVUM80Pl6/p+nOJMcWvAJWfhyOY0NZBS0IFRp60TivlKTymBgosJJStJbdFe/yFuYVsKxKsv3LtycDu9kIfhuWOu6Pqu4LvUA3ejlp0uwWfIegIcp3OS3vTcjE/IFtLwZOVxUMU5gJulHzYa4bMKijDG4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707434494; c=relaxed/simple; bh=60al6aR3IeqYn6BMp8i4fBsFK9rcGV6TnQtZSvQs/Bo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=sB11BeTpSF5vYlY7LWeIBvZGbLQizmFV0aL7FNFRqOnhrfxiuU31OOBhULtJCsh9SUV8zgLCUnDnKPjkQHHu0hcJ/Sgjygdqfld4+D4a6CplQiqw/ZFNQaSG4v2a3PKcykcWDkWKOk8Lb3Ed75Ry/PUcwngjzyMOmNqQbdgzQiM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=IRiT8Q+y; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=cguztqya; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="IRiT8Q+y"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="cguztqya" Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 418LSxbI019784; Thu, 8 Feb 2024 23:21:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-11-20; bh=u0ClYQ06XNLo1CSQD37fKO9EGTousxX+6TVz2GY0UNY=; b=IRiT8Q+yWZ90XNUwuS5eLwk6IueAPgYPF5xs2As2MlAHs7hf6BI36cd9604GwN8Nvm3O rLjQEqEDIRUfttStp1nIarnN/mzKOkIm6JbHjh4QqudgcLDRJ2K4WmQdS7TX/dEeNQqE FNprMRlF0ZwBezl7rHlZRoddkmYRfSrqfjQWWb9je3oCfqxFy6BCfUQTeixLqSFsyCa6 kqryYyqG7DBN6FFGrmN1IKMaoUr3aqi/VilCkXilsC9PdwVUEhRN65Yngu/TtdEXf4og H9qGcPsqbICFG9QHY+fFokN7MAFXprsioJAgCXRUYfPr+gYslOoAZzVeiQ+odq247QwW AQ== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3w1bwewx48-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Feb 2024 23:21:30 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 418Msnx5039462; Thu, 8 Feb 2024 23:21:29 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2168.outbound.protection.outlook.com [104.47.57.168]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3w1bxb4y50-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Feb 2024 23:21:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZWnGJaijK7WNhoUZg8if64BBR3ZRWiMTAkhiF8xYf+9NCxbjiPOFA8A4HRzl6OyX1GQpACzNdWJEx3uXtttA7JciR+VGVNF+k1eQXuEaCJm72ZsCskuxfWmDjvPVKDWbgD23WkOVbgltX7HOrYGBYyGUvRqDmSLUoeHWhbdtXV4ZUVRArpiPhFfw3ZVoZ51K+4NHOalbOsAY08gNk3j6MEya3xvH5ficbeveqk8wgYcd490luuUAn8qsyuHET7bfQe0yCSKfOEE1166kpxCT8J7RSkRZFxmwkmJYWA5tO2nh1M5Ah0eeyhyfLC2FDu9zDJDP5z4GM+G5wufZXtmlUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u0ClYQ06XNLo1CSQD37fKO9EGTousxX+6TVz2GY0UNY=; b=lY7rjYfsKt8D6yhcN2voAaE5vydgKfr9CSTVxows1EP+oD1KKqZdNU1v5nCVaKCAmNhznrHmdGn0tmRyTheWYFI8Wfxy8xMRlnsAjZTIAj7jHVRJXEUiXgztWFF99DgDOA1lCfJyiOk0SNl8Hr8VHl7ek7snoG6LWoWBZD4IE2iHIihINDV4O0ih3GShs2kSte14txqOYw1wkW8PYgu5RW8gJw0cVBHxJgZjyMvOGf7RihgvvVjyF/QXzVDUXMSr3VZdzDFzobnnG+Sd3HXgDNCpyRn5tBFG/2yiFBw5cEKiBBvaqW5lisOPYZMoCSj1WqSQif93D8bUebWDfB1InQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u0ClYQ06XNLo1CSQD37fKO9EGTousxX+6TVz2GY0UNY=; b=cguztqyaCuqVLQOVPmZXTI3tPR8uhBcM1q8ZThYNDQS2dHphPi7G5JxXWyVgJJd2t4bq3RDOYMpupsvfeyfh8Gp6up9+dtayqsw1Rg35ZA/6ArtG4Vf9KsPzz+za54u4NnljKAK+7MlwuDaknt57/PYQ3cUywy6wD2O2/noSaqM= Received: from BLAPR10MB5316.namprd10.prod.outlook.com (2603:10b6:208:326::6) by DM4PR10MB6014.namprd10.prod.outlook.com (2603:10b6:8:ad::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.37; Thu, 8 Feb 2024 23:21:27 +0000 Received: from BLAPR10MB5316.namprd10.prod.outlook.com ([fe80::abec:4916:93a1:2f72]) by BLAPR10MB5316.namprd10.prod.outlook.com ([fe80::abec:4916:93a1:2f72%6]) with mapi id 15.20.7270.024; Thu, 8 Feb 2024 23:21:27 +0000 From: Catherine Hoang <catherine.hoang@oracle.com> To: stable@vger.kernel.org Cc: linux-xfs@vger.kernel.org Subject: [PATCH 6.6 15/21] xfs: fix internal error from AGFL exhaustion Date: Thu, 8 Feb 2024 15:20:48 -0800 Message-Id: <20240208232054.15778-16-catherine.hoang@oracle.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20240208232054.15778-1-catherine.hoang@oracle.com> References: <20240208232054.15778-1-catherine.hoang@oracle.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: BY5PR17CA0029.namprd17.prod.outlook.com (2603:10b6:a03:1b8::42) To BLAPR10MB5316.namprd10.prod.outlook.com (2603:10b6:208:326::6) Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: <linux-xfs.vger.kernel.org> List-Subscribe: <mailto:linux-xfs+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-xfs+unsubscribe@vger.kernel.org> MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5316:EE_|DM4PR10MB6014:EE_ X-MS-Office365-Filtering-Correlation-Id: a8218333-198e-4631-47e4-08dc28fcacd2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: im36xvQUuVqYpgVh9sLK7uEUtRPqRJizuvdI9SIVcVLIRUKo7agCKIcv2g97qceY83ALJMafeWUmqwpPkVmJPcU/L2trRdeHl/g/IJj9IvYWYX0mxT9JctUKhNIq7wzd82xetVgc5Szg/jlzl8MdzsQ9IQvWMekPafRz6w77+V1sRxuWGFG3f4gLNMt9v8NkbxMni7qI5WX7CGrGcwarwkQXluW5+ppo74fxfNgf6TnGVjGIGXvVIJNXoWXyLLzFQ/8/6uw7EGCl0isQ9/iwbFm0WD1juv+uNLa2JU3/DliqMKN9Neg8ipaWxapnCo0oLcePy+w6d7FC67sg7tKCzDjfF2qwQSu+Rci9+MkQ72o4fmOMA9Nna7AI+2ChqDQyHudR4WmHeWaCmhbX+um4KMQ1C93WDigH4kczqukEZKLUZ9/NsgzJ9w6nVEgY+Rysmulm3YdyKdotY1DEVAXTFDqcNLZZKN5jdk46z4lC+Few027ot+4vTUFZMc97DvXuxt4qUV0yEC/zaTdRruX8ezRMTKAnc2CW9jwPhmcrM8NmYadq045cZP4FHiwypxYa X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5316.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(346002)(136003)(396003)(366004)(39860400002)(230922051799003)(64100799003)(186009)(451199024)(1800799012)(86362001)(38100700002)(41300700001)(83380400001)(2906002)(66946007)(2616005)(66476007)(66556008)(6916009)(316002)(6666004)(36756003)(8936002)(1076003)(44832011)(4326008)(8676002)(450100002)(478600001)(6486002)(6506007)(5660300002)(6512007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: CK2RTt3+yxVJjowDu6RVAzwcLtdBBmaEB5ZT6/al969M/jq1LWZRh1Esg/zsPUTmVbfWs53AfaitozfGITd8z33mmrpQKbfMui/mx6R5fnTSNbwiyafmk4MJYkRAzqtip7voiJgMNAQeE1RBtUjjmCCo5D8MT79iz/FcsijLpTCHI45G+MGneVUvATM7s0kaS6iQAsBFQnUEdFGV2TmW7E1VmGLVKlvL9LxTS4nSQiVF3gh1S7dINMej5pjRD6kHiUzPcNuO/T8Gf2/r5kpk9bLn8vZ1ulK4/OQQ02Vv2K4bbHK7tzKZBFuNGXR5W2/YnwLEgDNoqMlIiiw+2UZBqxQWkcxSfZvx/6J4ZblJunAW99Y8ovCZPe8ogeAWpp/r1qCSbpsTZy7APTTN3bVQ+7VPDBLBHuTUw2kB0z3WK2e+Zv99Hlu1G1XCIPqdRH/y07TpTsMTOhxQEB5EAYLmi5rFG7c0lX0PfP3qRFFvih8SWRF87xynvDeY12uXBz7AHsx2aLWEoEXJkexp1BWr8zxE93WDPnDW5mmv289Ka7wULqQV0ZwMQ8rKrf3joqtnGAB30Nl1m9gx92XeLO92WwLRUWNcSQwwNW1FsdpHbpgE3xS+MFJNA9zXqrzOq/oBGakhCcHMHGuXGdj0zzU0ozfFoWqXN86vJ56kec+FKKLvMNhfzKz262jlLh6bRZ0iWe/Ra3TmlKvonhw1max94nOLuz9F6Ku5agDR9fEBpjGdC1xP135JaI4I4/T61ULnAS+RNubBnfiAF4YhHSHziOdwuues++ZZ2Z7+lAtswqtD6FyxJPJXqAMvvnx9nrohL/+5RNAt/KmXIFTHNhA5gU7Iws6OB6VZwNB9ssB7y8Q1Ix1ydej/NoA4WmqDiglhHOugEB/U7YTmwF11fGakUge8SfSbpFyiF27Qb+LzEdwjQmYwxheBcGNKlybZMt/AASZLcxqPWIYnYaesdZJBSnKanHapJWtOkmE0PWZVhklLfFuaSMv+cbzEVNlwaT+GR3qHLtO+Pll93DpmGrZvEuxUW1tdpw743SoZgNB8mT3LXnE/8VoFNzl8CIKJlzmlGu17IsKMOysw0BVmqWQHMIO+cjOXUXeHHCgUDfKqegBIVOUAB1zRPWShWtZFsh8t5pBHKThxUbI8lXBopkF6oAZUNfKCdFl5UquPXFUArLIEk2ZbwUuWowE10oDgNUMxak2AKn0rXdxw/yMi0RYAYIVJ8o8WpKCOZ4RRN2Azv14YiX45KBnox1eNsOWLj/FVnTEdn3fNKn/od4VffiM1cnqS7Z78tsjFynBRRlvhM3coSo5VOBj6pcSeFItX/1GBWLhv1PMGTDUjHjrWlHCQBk1dr8P4EVrfzWCITsCBsVbCFVD5CRqxLY9GggQgYx19/vUD7eXDKpXDteG/U/gu4IAZ89NOPsWzGJVnCX4B66pdKhmYqeJFUKklhY63Bk0dGpYSC0QrV8qgl652uyxdUK4lSYBXfEV8Ez42XzynBiV/COqjm536YURNXBJWSfTmocNBbf0Xgx5kSYUTDL/gH8r9omuwYl/LmXf/qlBb6CfmhgUvnzulVxGSHdFx0UdVuen7/1CgE0xhpZ5gFRF7FOttzTBPKfTiI5sjJYb3IzaFP8ymx54XTDzA7h83KwZlBsZ0Wo6og5zHnPe5K/1IXQ== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: l94NrD4vQhPY5b77hOIO6SU0IT02wkdUumhbCkOy0M7tIBF5m2FJRuJRjwuawEI/Fcap/TesBXIqIrl7jVHs5njca8+4MsIJ4IH+BPLyCS4SIxtJv5XdSCXQ8QjswMFWgnfgpPlEzyAPRiA+MUH0wBWrJFEFKK5StrNQOROXPs7KmUftQ5acZs4rM9SsIvnvC72uCmtV1G3A9XyRts2HF3xhyfuzr7QUC+QXjwq8TD6EpX5lMO9iyi7IZ8966mZmMM8qtNH9L4bMWABEHU2f9D4G3iTSXsUGtKbWBttA8bUbyZwIoZVa4zLM9YuTDjocDZ+YARrYBk4BWSI3EGStEmEwoKouex8rLH+yA97+UNOvEgQfb5Ky6ee0rTwYLTvIohZV8ei1pYN5t3mcV8jngeXS5Tzi1pOrzLRxHCp9Zeb0iLRbKExnqzvJzKytxnooOv6udqYc2pRc9Q+jWQx4gCwBavbSCj3mqEw3R9Tl7wADObmZFoHQjNPWkA7mzC06IpJRFxMIl5iXRFRfYAmfJ2HdHQhNGHDMfiMtE3V7cd6CHSocSmWklo3q5DKSSkEju6nS4M/+Wk6Bdzos1PIr11fdIL0jSsQvObyK/MrOWO4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8218333-198e-4631-47e4-08dc28fcacd2 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5316.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 23:21:27.8161 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eTlNNwk4NeMvUQJ351VjpMaKf+LuISEDvMG5baBTfO/BNDmiBBQAvrTaRotQbJgrKl0mUC7u/vM17TVC+A6S1LWUSwUeNSJ/j13Bj2XnubM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6014 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-08_11,2024-02-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 phishscore=0 spamscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402080132 X-Proofpoint-ORIG-GUID: KI8kn8RBjg8iuUf4OB7qfhTMi0QwA0ce X-Proofpoint-GUID: KI8kn8RBjg8iuUf4OB7qfhTMi0QwA0ce |
Series |
xfs backports for 6.6.y (from v6.7)
|
expand
|
diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c index 3069194527dd..100ab5931b31 100644 --- a/fs/xfs/libxfs/xfs_alloc.c +++ b/fs/xfs/libxfs/xfs_alloc.c @@ -2275,16 +2275,37 @@ xfs_alloc_min_freelist( ASSERT(mp->m_alloc_maxlevels > 0); + /* + * For a btree shorter than the maximum height, the worst case is that + * every level gets split and a new level is added, then while inserting + * another entry to refill the AGFL, every level under the old root gets + * split again. This is: + * + * (full height split reservation) + (AGFL refill split height) + * = (current height + 1) + (current height - 1) + * = (new height) + (new height - 2) + * = 2 * new height - 2 + * + * For a btree of maximum height, the worst case is that every level + * under the root gets split, then while inserting another entry to + * refill the AGFL, every level under the root gets split again. This is + * also: + * + * 2 * (current height - 1) + * = 2 * (new height - 1) + * = 2 * new height - 2 + */ + /* space needed by-bno freespace btree */ min_free = min_t(unsigned int, levels[XFS_BTNUM_BNOi] + 1, - mp->m_alloc_maxlevels); + mp->m_alloc_maxlevels) * 2 - 2; /* space needed by-size freespace btree */ min_free += min_t(unsigned int, levels[XFS_BTNUM_CNTi] + 1, - mp->m_alloc_maxlevels); + mp->m_alloc_maxlevels) * 2 - 2; /* space needed reverse mapping used space btree */ if (xfs_has_rmapbt(mp)) min_free += min_t(unsigned int, levels[XFS_BTNUM_RMAPi] + 1, - mp->m_rmap_maxlevels); + mp->m_rmap_maxlevels) * 2 - 2; return min_free; }