diff mbox series

libxfs: print the device name if flush-on-close fails

Message ID 20240417231650.GE11948@frogsfrogsfrogs (mailing list archive)
State Accepted
Headers show
Series libxfs: print the device name if flush-on-close fails | expand

Commit Message

Darrick J. Wong April 17, 2024, 11:16 p.m. UTC 
From: Darrick J. Wong <djwong@kernel.org>

Print the name of the device if persisting the write cache fails.
Printing a pointer does not help the user at all, and this causes the
32-bit build to complain:

init.c: In function ‘libxfs_device_close’:
init.c:178:35: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
  178 |                         progname, (long long)dev, ret);
      |                                   ^
cc1: all warnings being treated as errors

Fixes: fc83c7574b1f ("libxfs: split out a libxfs_dev structure from struct libxfs_init")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 libxfs/init.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Christoph Hellwig April 18, 2024, 4:26 a.m. UTC | #1 
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/libxfs/init.c b/libxfs/init.c
index 1e035c48f57f..6ac9d682490a 100644
--- a/libxfs/init.c
+++ b/libxfs/init.c
@@ -171,8 +171,8 @@  libxfs_device_close(
 	if (ret) {
 		ret = -errno;
 		fprintf(stderr,
-	_("%s: flush of device %lld failed, err=%d"),
-			progname, (long long)dev, ret);
+	_("%s: flush of device %s failed, err=%d"),
+			progname, dev->name, ret);
 	}
 	close(dev->fd);