diff mbox series

[9/9] mm,page_owner: don't remove GFP flags in add_stack_record_to_list

Message ID 20240429061529.1550204-10-hch@lst.de (mailing list archive)
State New
Headers show
Series [1/9] xfs: fix error returns from xfs_bmapi_write | expand

Commit Message

Christoph Hellwig April 29, 2024, 6:15 a.m. UTC
This loses flags like GFP_NOFS and GFP_NOIO that are important to avoid
deadlocks as well as GFP_NOLOCKDEP that otherwise generates lockdep false
positives.

Fixes: 217b2119b9e2 ("mm,page_owner: implement the tracking of the stacks count")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 mm/page_owner.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Christoph Hellwig April 29, 2024, 6:17 a.m. UTC | #1
Please discard one, I developed this on the currently checked out tree,
but it has been sent separately.
diff mbox series

Patch

diff --git a/mm/page_owner.c b/mm/page_owner.c
index d17d1351ec84af..d214488846fa92 100644
--- a/mm/page_owner.c
+++ b/mm/page_owner.c
@@ -168,9 +168,7 @@  static void add_stack_record_to_list(struct stack_record *stack_record,
 	unsigned long flags;
 	struct stack *stack;
 
-	/* Filter gfp_mask the same way stackdepot does, for consistency */
 	gfp_mask &= ~GFP_ZONEMASK;
-	gfp_mask &= (GFP_ATOMIC | GFP_KERNEL);
 	gfp_mask |= __GFP_NOWARN;
 
 	set_current_in_page_owner();