| Message ID | 20240522220656.8460-1-bage@debian.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | xfs_io: make MADV_SOFT_OFFLINE conditional | expand |
On Thu, May 23, 2024 at 12:06:56AM +0200, Bastian Germann wrote: > mips64el does not have the symbol MADV_SOFT_OFFLINE, so wrap it in an > ifdef. > > Signed-off-by: Bastian Germann <bage@debian.org> > --- > io/madvise.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/io/madvise.c b/io/madvise.c > index ede23395..1d664f8d 100644 > --- a/io/madvise.c > +++ b/io/madvise.c > @@ -101,9 +101,11 @@ madvise_f( > case 'M': /* disable merging */ > advise = MADV_UNMERGEABLE; > break; > +#ifdef MADV_SOFT_OFFLINE > case 'o': /* offline */ > advise = MADV_SOFT_OFFLINE; > break; > +#endif Please #ifdef guard the -o line in madvise_help so it doesn't show up in the help screen on mips64el. With that added, Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > case 'p': /* punch hole */ > advise = MADV_REMOVE; > break; > -- > 2.45.0 > >
diff --git a/io/madvise.c b/io/madvise.c index ede23395..1d664f8d 100644 --- a/io/madvise.c +++ b/io/madvise.c @@ -101,9 +101,11 @@ madvise_f( case 'M': /* disable merging */ advise = MADV_UNMERGEABLE; break; +#ifdef MADV_SOFT_OFFLINE case 'o': /* offline */ advise = MADV_SOFT_OFFLINE; break; +#endif case 'p': /* punch hole */ advise = MADV_REMOVE; break;
mips64el does not have the symbol MADV_SOFT_OFFLINE, so wrap it in an ifdef. Signed-off-by: Bastian Germann <bage@debian.org> --- io/madvise.c | 2 ++ 1 file changed, 2 insertions(+)