| Message ID | 20240709073444.3023076-1-hch@lst.de (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [v2] libxfs: remove duplicate rtalloc declarations in libxfs.h | expand |
On Tue, Jul 09, 2024 at 09:34:31AM +0200, Christoph Hellwig wrote: > These already come from xfs_rtbitmap.h. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > > Changes since v1: > - now without spurious man page removal > > include/libxfs.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/include/libxfs.h b/include/libxfs.h > index fb8efb696..40e41ea77 100644 > --- a/include/libxfs.h > +++ b/include/libxfs.h > @@ -220,11 +220,6 @@ libxfs_bmbt_disk_get_all( > irec->br_state = XFS_EXT_NORM; > } > > -/* XXX: this is clearly a bug - a shared header needs to export this */ > -/* xfs_rtalloc.c */ > -int libxfs_rtfree_extent(struct xfs_trans *, xfs_rtblock_t, xfs_extlen_t); > -bool libxfs_verify_rtbno(struct xfs_mount *mp, xfs_rtblock_t rtbno); > - > #include "xfs_attr.h" > #include "topology.h" Looks good now. Reviewed-by: Dave Chinner <dchinner@redhat.com>
On Tue, Jul 09, 2024 at 09:34:31AM +0200, Christoph Hellwig wrote: > These already come from xfs_rtbitmap.h. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Looks good now, Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > > Changes since v1: > - now without spurious man page removal > > include/libxfs.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/include/libxfs.h b/include/libxfs.h > index fb8efb696..40e41ea77 100644 > --- a/include/libxfs.h > +++ b/include/libxfs.h > @@ -220,11 +220,6 @@ libxfs_bmbt_disk_get_all( > irec->br_state = XFS_EXT_NORM; > } > > -/* XXX: this is clearly a bug - a shared header needs to export this */ > -/* xfs_rtalloc.c */ > -int libxfs_rtfree_extent(struct xfs_trans *, xfs_rtblock_t, xfs_extlen_t); > -bool libxfs_verify_rtbno(struct xfs_mount *mp, xfs_rtblock_t rtbno); > - > #include "xfs_attr.h" > #include "topology.h" > > -- > 2.43.0 > >
diff --git a/include/libxfs.h b/include/libxfs.h index fb8efb696..40e41ea77 100644 --- a/include/libxfs.h +++ b/include/libxfs.h @@ -220,11 +220,6 @@ libxfs_bmbt_disk_get_all( irec->br_state = XFS_EXT_NORM; } -/* XXX: this is clearly a bug - a shared header needs to export this */ -/* xfs_rtalloc.c */ -int libxfs_rtfree_extent(struct xfs_trans *, xfs_rtblock_t, xfs_extlen_t); -bool libxfs_verify_rtbno(struct xfs_mount *mp, xfs_rtblock_t rtbno); - #include "xfs_attr.h" #include "topology.h"
These already come from xfs_rtbitmap.h. Signed-off-by: Christoph Hellwig <hch@lst.de> --- Changes since v1: - now without spurious man page removal include/libxfs.h | 5 ----- 1 file changed, 5 deletions(-)