| Message ID | 20240709073632.1152995-1-nichen@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | xfs: convert comma to semicolon | expand |
On Tue, Jul 09, 2024 at 03:36:32PM +0800, Chen Ni wrote: > Replace a comma between expression statements by a semicolon. Fixes: 8f4b980ee67f ("xfs: pass the attr value to put_listent when possible") > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > --- > fs/xfs/xfs_attr_list.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c > index 5c947e5ce8b8..7db386304875 100644 > --- a/fs/xfs/xfs_attr_list.c > +++ b/fs/xfs/xfs_attr_list.c > @@ -139,7 +139,7 @@ xfs_attr_shortform_list( > sbp->name = sfe->nameval; > sbp->namelen = sfe->namelen; > /* These are bytes, and both on-disk, don't endian-flip */ > - sbp->value = &sfe->nameval[sfe->namelen], > + sbp->value = &sfe->nameval[sfe->namelen]; > sbp->valuelen = sfe->valuelen; > sbp->flags = sfe->flags; > sbp->hash = xfs_attr_hashval(dp->i_mount, sfe->flags, Looks good, Reviewed-by: Dave Chinner <dchinner@redhat.com>
On Tue, Jul 09, 2024 at 03:36:32PM +0800, Chen Ni wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > --- LGTM Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > fs/xfs/xfs_attr_list.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c > index 5c947e5ce8b8..7db386304875 100644 > --- a/fs/xfs/xfs_attr_list.c > +++ b/fs/xfs/xfs_attr_list.c > @@ -139,7 +139,7 @@ xfs_attr_shortform_list( > sbp->name = sfe->nameval; > sbp->namelen = sfe->namelen; > /* These are bytes, and both on-disk, don't endian-flip */ > - sbp->value = &sfe->nameval[sfe->namelen], > + sbp->value = &sfe->nameval[sfe->namelen]; > sbp->valuelen = sfe->valuelen; > sbp->flags = sfe->flags; > sbp->hash = xfs_attr_hashval(dp->i_mount, sfe->flags, > -- > 2.25.1 > >
On 7/9/2024 12:36 AM, Chen Ni wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Chen Ni<nichen@iscas.ac.cn> Looks good. Reviewed-by : Chaitanya Kulkarni <kch@nvidia.com> -ck
diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c index 5c947e5ce8b8..7db386304875 100644 --- a/fs/xfs/xfs_attr_list.c +++ b/fs/xfs/xfs_attr_list.c @@ -139,7 +139,7 @@ xfs_attr_shortform_list( sbp->name = sfe->nameval; sbp->namelen = sfe->namelen; /* These are bytes, and both on-disk, don't endian-flip */ - sbp->value = &sfe->nameval[sfe->namelen], + sbp->value = &sfe->nameval[sfe->namelen]; sbp->valuelen = sfe->valuelen; sbp->flags = sfe->flags; sbp->hash = xfs_attr_hashval(dp->i_mount, sfe->flags,
Replace a comma between expression statements by a semicolon. Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- fs/xfs/xfs_attr_list.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)