diff mbox series

[3/5] xfs/424: don't use _min_dio_alignment

Message ID 20240813073527.81072-4-hch@lst.de (mailing list archive)
State Superseded, archived
Headers show
Series [1/5] statx.h: update to latest kernel UAPI | expand

Commit Message

Christoph Hellwig Aug. 13, 2024, 7:35 a.m. UTC
xfs/424 tests xfs_db and not the kernel xfs code, and really wants
the device sector size and not the minimum direct I/O alignment.

Switch to a direct call of the blockdev utility.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 tests/xfs/424 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Darrick J. Wong Aug. 13, 2024, 2:40 p.m. UTC | #1
On Tue, Aug 13, 2024 at 09:35:02AM +0200, Christoph Hellwig wrote:
> xfs/424 tests xfs_db and not the kernel xfs code, and really wants
> the device sector size and not the minimum direct I/O alignment.
> 
> Switch to a direct call of the blockdev utility.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  tests/xfs/424 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/424 b/tests/xfs/424
> index 71d48bec1..6078d3489 100755
> --- a/tests/xfs/424
> +++ b/tests/xfs/424
> @@ -50,7 +50,7 @@ echo "Silence is golden."
>  # NOTE: skip attr3, bmapbta, bmapbtd, dir3, dqblk, inodata, symlink
>  # rtbitmap, rtsummary, log
>  #
> -sec_sz=`_min_dio_alignment $SCRATCH_DEV`
> +sec_sz=`blockdev --getss $SCRATCH_DEV`
>  while [ $sec_sz -le 4096 ]; do
>  	sector_sizes="$sector_sizes $sec_sz"
>  	sec_sz=$((sec_sz * 2))
> -- 
> 2.43.0
> 
>
diff mbox series

Patch

diff --git a/tests/xfs/424 b/tests/xfs/424
index 71d48bec1..6078d3489 100755
--- a/tests/xfs/424
+++ b/tests/xfs/424
@@ -50,7 +50,7 @@  echo "Silence is golden."
 # NOTE: skip attr3, bmapbta, bmapbtd, dir3, dqblk, inodata, symlink
 # rtbitmap, rtsummary, log
 #
-sec_sz=`_min_dio_alignment $SCRATCH_DEV`
+sec_sz=`blockdev --getss $SCRATCH_DEV`
 while [ $sec_sz -le 4096 ]; do
 	sector_sizes="$sector_sizes $sec_sz"
 	sec_sz=$((sec_sz * 2))