| Message ID | 20240910042855.3480387-5-hch@lst.de (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/4] xfs: pass the exact range to initialize to xfs_initialize_perag | expand |
On Tue, Sep 10, 2024 at 07:28:47AM +0300, Christoph Hellwig wrote: > __GFP_RETRY_MAYFAIL increases the likelyhood of allocations to fail, > which isn't really helpful during log recovery. Remove the flag and > stick to the default GFP_KERNEL policies. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Sounds fine to me Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > fs/xfs/libxfs/xfs_ag.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/libxfs/xfs_ag.c b/fs/xfs/libxfs/xfs_ag.c > index 3f695100d7ab58..f6c666a87dd393 100644 > --- a/fs/xfs/libxfs/xfs_ag.c > +++ b/fs/xfs/libxfs/xfs_ag.c > @@ -289,7 +289,7 @@ xfs_initialize_perag( > return 0; > > for (index = old_agcount; index < agcount; index++) { > - pag = kzalloc(sizeof(*pag), GFP_KERNEL | __GFP_RETRY_MAYFAIL); > + pag = kzalloc(sizeof(*pag), GFP_KERNEL); > if (!pag) { > error = -ENOMEM; > goto out_unwind_new_pags; > -- > 2.45.2 > >
diff --git a/fs/xfs/libxfs/xfs_ag.c b/fs/xfs/libxfs/xfs_ag.c index 3f695100d7ab58..f6c666a87dd393 100644 --- a/fs/xfs/libxfs/xfs_ag.c +++ b/fs/xfs/libxfs/xfs_ag.c @@ -289,7 +289,7 @@ xfs_initialize_perag( return 0; for (index = old_agcount; index < agcount; index++) { - pag = kzalloc(sizeof(*pag), GFP_KERNEL | __GFP_RETRY_MAYFAIL); + pag = kzalloc(sizeof(*pag), GFP_KERNEL); if (!pag) { error = -ENOMEM; goto out_unwind_new_pags;
__GFP_RETRY_MAYFAIL increases the likelyhood of allocations to fail, which isn't really helpful during log recovery. Remove the flag and stick to the default GFP_KERNEL policies. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/xfs/libxfs/xfs_ag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)