| Message ID | 20240930125438.2501050-8-john.g.garry@oracle.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | block atomic writes for xfs | expand |
On Mon, Sep 30, 2024 at 12:54:38PM +0000, John Garry wrote: > For when an inode is enabled for atomic writes, set FMODE_CAN_ATOMIC_WRITE > flag. Only direct IO is currently supported, so check for that also. > > Signed-off-by: John Garry <john.g.garry@oracle.com> Looks good, Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > fs/xfs/xfs_file.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index fa6a44b88ecc..a358657a1ae6 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -1208,6 +1208,16 @@ xfs_file_remap_range( > return remapped > 0 ? remapped : ret; > } > > +static bool > +xfs_file_open_can_atomicwrite( > + struct inode *inode, > + struct file *file) > +{ > + if (!(file->f_flags & O_DIRECT)) > + return false; > + return xfs_inode_can_atomicwrite(XFS_I(inode)); > +} > + > STATIC int > xfs_file_open( > struct inode *inode, > @@ -1216,6 +1226,8 @@ xfs_file_open( > if (xfs_is_shutdown(XFS_M(inode->i_sb))) > return -EIO; > file->f_mode |= FMODE_NOWAIT | FMODE_CAN_ODIRECT; > + if (xfs_file_open_can_atomicwrite(inode, file)) > + file->f_mode |= FMODE_CAN_ATOMIC_WRITE; > return generic_file_open(inode, file); > } > > -- > 2.31.1 > >
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index fa6a44b88ecc..a358657a1ae6 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c @@ -1208,6 +1208,16 @@ xfs_file_remap_range( return remapped > 0 ? remapped : ret; } +static bool +xfs_file_open_can_atomicwrite( + struct inode *inode, + struct file *file) +{ + if (!(file->f_flags & O_DIRECT)) + return false; + return xfs_inode_can_atomicwrite(XFS_I(inode)); +} + STATIC int xfs_file_open( struct inode *inode, @@ -1216,6 +1226,8 @@ xfs_file_open( if (xfs_is_shutdown(XFS_M(inode->i_sb))) return -EIO; file->f_mode |= FMODE_NOWAIT | FMODE_CAN_ODIRECT; + if (xfs_file_open_can_atomicwrite(inode, file)) + file->f_mode |= FMODE_CAN_ATOMIC_WRITE; return generic_file_open(inode, file); }
For when an inode is enabled for atomic writes, set FMODE_CAN_ATOMIC_WRITE flag. Only direct IO is currently supported, so check for that also. Signed-off-by: John Garry <john.g.garry@oracle.com> --- fs/xfs/xfs_file.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)