| Message ID | 20241211085636.1380516-39-hch@lst.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [01/43] xfs: constify feature checks | expand |
On Wed, Dec 11, 2024 at 09:55:03AM +0100, Christoph Hellwig wrote: > Enable the zoned RT device directory feature. With this feature, RT > groups are written sequentially and always emptied before rewriting > the blocks. This perfectly maps to zoned devices, but can also be > used on conventional block devices. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Looks ok, though it's a bit odd that this isn't the very end of the series. Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> --D > --- > fs/xfs/libxfs/xfs_format.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h > index 12979496f30a..fc56de8fe696 100644 > --- a/fs/xfs/libxfs/xfs_format.h > +++ b/fs/xfs/libxfs/xfs_format.h > @@ -408,7 +408,8 @@ xfs_sb_has_ro_compat_feature( > XFS_SB_FEAT_INCOMPAT_NREXT64 | \ > XFS_SB_FEAT_INCOMPAT_EXCHRANGE | \ > XFS_SB_FEAT_INCOMPAT_PARENT | \ > - XFS_SB_FEAT_INCOMPAT_METADIR) > + XFS_SB_FEAT_INCOMPAT_METADIR | \ > + XFS_SB_FEAT_INCOMPAT_ZONED) > > #define XFS_SB_FEAT_INCOMPAT_UNKNOWN ~XFS_SB_FEAT_INCOMPAT_ALL > static inline bool > -- > 2.45.2 > >
On Fri, Dec 13, 2024 at 02:52:45PM -0800, Darrick J. Wong wrote: > On Wed, Dec 11, 2024 at 09:55:03AM +0100, Christoph Hellwig wrote: > > Enable the zoned RT device directory feature. With this feature, RT > > groups are written sequentially and always emptied before rewriting > > the blocks. This perfectly maps to zoned devices, but can also be > > used on conventional block devices. > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > Looks ok, though it's a bit odd that this isn't the very end of the > series. The rest of the series adds another on-disk feature build on top of this (the zone gaps) and new in-memory only features (debug output in /proc/self/mountstats and hint based data placement). So I tried to keep the bracket of adding the first bits for a new feature and enabling it as small as possible (it's already pretty large anyway).
diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h index 12979496f30a..fc56de8fe696 100644 --- a/fs/xfs/libxfs/xfs_format.h +++ b/fs/xfs/libxfs/xfs_format.h @@ -408,7 +408,8 @@ xfs_sb_has_ro_compat_feature( XFS_SB_FEAT_INCOMPAT_NREXT64 | \ XFS_SB_FEAT_INCOMPAT_EXCHRANGE | \ XFS_SB_FEAT_INCOMPAT_PARENT | \ - XFS_SB_FEAT_INCOMPAT_METADIR) + XFS_SB_FEAT_INCOMPAT_METADIR | \ + XFS_SB_FEAT_INCOMPAT_ZONED) #define XFS_SB_FEAT_INCOMPAT_UNKNOWN ~XFS_SB_FEAT_INCOMPAT_ALL static inline bool
Enable the zoned RT device directory feature. With this feature, RT groups are written sequentially and always emptied before rewriting the blocks. This perfectly maps to zoned devices, but can also be used on conventional block devices. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/xfs/libxfs/xfs_format.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)