[v1.1,1/2] mkfs,xfs_repair: don't pass a daddr as the flags argument

Commit Message

Darrick J. Wong Feb. 19, 2025, 5:46 a.m. UTC

From: Darrick J. Wong <[e-mail]>

libxfs_buf_get_uncached doesn't take a daddr argument, so don't pass one
as the flags argument.

Cc: <[e-mail]> # v6.13.0
Fixes: 0d7c490474e5e5 ("mkfs: format realtime groups")
Signed-off-by: "Darrick J. Wong" <[e-mail]>
---
v1.1: drop the xfs_buf_set_addr change
---
 mkfs/xfs_mkfs.c |    3 +--
 repair/rt.c     |    2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

Comments

Christoph Hellwig Feb. 19, 2025, 5:49 a.m. UTC | #1

Looks good:

Reviewed-by: Christoph Hellwig <[e-mail]>

Patch

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index f5556fcc4040ed..86bc9865b1071e 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -4989,8 +4989,7 @@  write_rtsb(
 	}
 
 	error = -libxfs_buf_get_uncached(mp->m_rtdev_targp,
-				XFS_FSB_TO_BB(mp, 1), XFS_RTSB_DADDR,
-				&rtsb_bp);
+				XFS_FSB_TO_BB(mp, 1), 0, &rtsb_bp);
 	if (error) {
 		fprintf(stderr,
  _("%s: couldn't grab realtime superblock buffer\n"), progname);
diff --git a/repair/rt.c b/repair/rt.c
index 5ba04919bc3ccf..e0a4943ee3b766 100644
--- a/repair/rt.c
+++ b/repair/rt.c
@@ -616,7 +616,7 @@  rewrite_rtsb(
  _("couldn't grab primary sb to update realtime sb\n"));
 
 	error = -libxfs_buf_get_uncached(mp->m_rtdev_targp,
-			XFS_FSB_TO_BB(mp, 1), XFS_RTSB_DADDR, &rtsb_bp);
+			XFS_FSB_TO_BB(mp, 1), 0, &rtsb_bp);
 	if (error)
 		do_error(
  _("couldn't grab realtime superblock\n"));