| Message ID | 20250219160500.2129135-1-tytso@mit.edu (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [XFSPROGS] make: remove the .extradep file in libxfs on "make clean" | expand |
On Wed, Feb 19, 2025 at 11:05:00AM -0500, Theodore Ts'o wrote: > Commit 6e1d3517d108 ("libxfs: test compiling public headers with a C++ > compiler") will create the .extradep file. This can cause future > builds to fail if the header files in $(DESTDIR) no longer exist. > > Fix this by removing .extradep (along with files like .ltdep) on a > "make clean". > > Fixes: 6e1d3517d108 ("libxfs: test compiling public headers with a C++ compiler") > Signed-off-by: Theodore Ts'o <tytso@mit.edu> Oops, yeah, I forgot that. :( Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> --D > --- > include/buildrules | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/buildrules b/include/buildrules > index 7a139ff0..6b76abce 100644 > --- a/include/buildrules > +++ b/include/buildrules > @@ -7,7 +7,7 @@ _BUILDRULES_INCLUDED_ = 1 > include $(TOPDIR)/include/builddefs > > clean clobber : $(addsuffix -clean,$(SUBDIRS)) > - @rm -f $(DIRT) .ltdep .dep > + @rm -f $(DIRT) .ltdep .dep .extradep > @rm -fr $(DIRDIRT) > %-clean: > @echo "Cleaning $*" > -- > 2.47.2 >
On Wed, Feb 19, 2025 at 11:05:00AM -0500, Theodore Ts'o wrote: > Commit 6e1d3517d108 ("libxfs: test compiling public headers with a C++ > compiler") will create the .extradep file. This can cause future > builds to fail if the header files in $(DESTDIR) no longer exist. > > Fix this by removing .extradep (along with files like .ltdep) on a > "make clean". > > Fixes: 6e1d3517d108 ("libxfs: test compiling public headers with a C++ compiler") > Signed-off-by: Theodore Ts'o <tytso@mit.edu> Looks good. Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com> > --- > include/buildrules | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/buildrules b/include/buildrules > index 7a139ff0..6b76abce 100644 > --- a/include/buildrules > +++ b/include/buildrules > @@ -7,7 +7,7 @@ _BUILDRULES_INCLUDED_ = 1 > include $(TOPDIR)/include/builddefs > > clean clobber : $(addsuffix -clean,$(SUBDIRS)) > - @rm -f $(DIRT) .ltdep .dep > + @rm -f $(DIRT) .ltdep .dep .extradep > @rm -fr $(DIRDIRT) > %-clean: > @echo "Cleaning $*" > -- > 2.47.2 > >
diff --git a/include/buildrules b/include/buildrules index 7a139ff0..6b76abce 100644 --- a/include/buildrules +++ b/include/buildrules @@ -7,7 +7,7 @@ _BUILDRULES_INCLUDED_ = 1 include $(TOPDIR)/include/builddefs clean clobber : $(addsuffix -clean,$(SUBDIRS)) - @rm -f $(DIRT) .ltdep .dep + @rm -f $(DIRT) .ltdep .dep .extradep @rm -fr $(DIRDIRT) %-clean: @echo "Cleaning $*"
Commit 6e1d3517d108 ("libxfs: test compiling public headers with a C++ compiler") will create the .extradep file. This can cause future builds to fail if the header files in $(DESTDIR) no longer exist. Fix this by removing .extradep (along with files like .ltdep) on a "make clean". Fixes: 6e1d3517d108 ("libxfs: test compiling public headers with a C++ compiler") Signed-off-by: Theodore Ts'o <tytso@mit.edu> --- include/buildrules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)