| Message ID | 20250312064541.664334-15-hch@lst.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [01/17] xfs/177: force a small file system size | expand |
On Wed, Mar 12, 2025 at 07:45:06AM +0100, Christoph Hellwig wrote: > The filestreams tests using _test_streams force a run on the data > section, but for internal RT zoned devices the data section can be tiny > and might not provide enough space. Skip these tests as they aren't > really useful when testing a zoned config anyway. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Looks ok, assuming you don't just want to kill filestreams entirely :) Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> --D > --- > common/filestreams | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/common/filestreams b/common/filestreams > index 00b28066873f..bb8459405b3e 100644 > --- a/common/filestreams > +++ b/common/filestreams > @@ -108,6 +108,11 @@ _test_streams() { > _scratch_mount > fi > > + # Skip these tests on zoned file systems as filestreams don't work > + # with the zoned allocator, and the above would force it into the > + # tiny data section only used for metadata anyway. > + _require_xfs_scratch_non_zoned > + > cd $SCRATCH_MNT > > # start $stream_count streams > -- > 2.45.2 > >
On Wed, Mar 12, 2025 at 01:26:03PM -0700, Darrick J. Wong wrote: > On Wed, Mar 12, 2025 at 07:45:06AM +0100, Christoph Hellwig wrote: > > The filestreams tests using _test_streams force a run on the data > > section, but for internal RT zoned devices the data section can be tiny > > and might not provide enough space. Skip these tests as they aren't > > really useful when testing a zoned config anyway. > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > Looks ok, assuming you don't just want to kill filestreams entirely :) Hans and I are in fact looking into ways to repurpose it for zone placement. But that might just end up reusing the mru cache and look a bit different to the user.
diff --git a/common/filestreams b/common/filestreams index 00b28066873f..bb8459405b3e 100644 --- a/common/filestreams +++ b/common/filestreams @@ -108,6 +108,11 @@ _test_streams() { _scratch_mount fi + # Skip these tests on zoned file systems as filestreams don't work + # with the zoned allocator, and the above would force it into the + # tiny data section only used for metadata anyway. + _require_xfs_scratch_non_zoned + cd $SCRATCH_MNT # start $stream_count streams
The filestreams tests using _test_streams force a run on the data section, but for internal RT zoned devices the data section can be tiny and might not provide enough space. Skip these tests as they aren't really useful when testing a zoned config anyway. Signed-off-by: Christoph Hellwig <hch@lst.de> --- common/filestreams | 5 +++++ 1 file changed, 5 insertions(+)