| Message ID | 20250312064541.664334-9-hch@lst.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [01/17] xfs/177: force a small file system size | expand |
On Wed, Mar 12, 2025 at 07:45:00AM +0100, Christoph Hellwig wrote: > Check for a few errors issued for unsupported zoned configurations in > _try_scratch_mkfs_xfs so that the test is not run instead of failed. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > common/xfs | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/common/xfs b/common/xfs > index 93260fdb4599..807454d3e03b 100644 > --- a/common/xfs > +++ b/common/xfs > @@ -160,6 +160,11 @@ _try_scratch_mkfs_xfs() > > grep -q crc=0 $tmp.mkfsstd && _force_xfsv4_mount_options > > + grep -q "zoned file systems do not support" $tmp.mkfserr && \ > + _notrun "Not supported on zoned file systems" > + grep -q "must be greater than the minimum" $tmp.mkfserr && \ Hmmm... this doesn't mention the word "zone" at all. Maybe that error message in calculate_zone_geometry should read: "realtime group count (%llu) must be greater than the minimum (%u) zone count" ? and I think you should post the xfsprogs zoned patches. --D > + _notrun "Zone count too small" > + > if [ $mkfs_status -eq 0 -a "$LARGE_SCRATCH_DEV" = yes ]; then > # manually parse the mkfs output to get the fs size in bytes > local fs_size > -- > 2.45.2 > >
On Wed, Mar 12, 2025 at 01:17:25PM -0700, Darrick J. Wong wrote: > > + grep -q "zoned file systems do not support" $tmp.mkfserr && \ > > + _notrun "Not supported on zoned file systems" > > + grep -q "must be greater than the minimum" $tmp.mkfserr && \ > > Hmmm... this doesn't mention the word "zone" at all. > > Maybe that error message in calculate_zone_geometry should read: > > "realtime group count (%llu) must be greater than the minimum (%u) zone count" ? Yeah. > and I think you should post the xfsprogs zoned patches. Still waiting for a baseline to post against, i.e. rtrmap and rtreflink being merged.
On Thu, Mar 13, 2025 at 08:26:37AM +0100, Christoph Hellwig wrote: > On Wed, Mar 12, 2025 at 01:17:25PM -0700, Darrick J. Wong wrote: > > > + grep -q "zoned file systems do not support" $tmp.mkfserr && \ > > > + _notrun "Not supported on zoned file systems" > > > + grep -q "must be greater than the minimum" $tmp.mkfserr && \ > > > > Hmmm... this doesn't mention the word "zone" at all. > > > > Maybe that error message in calculate_zone_geometry should read: > > > > "realtime group count (%llu) must be greater than the minimum (%u) zone count" ? > > Yeah. > > > and I think you should post the xfsprogs zoned patches. > > Still waiting for a baseline to post against, i.e. rtrmap and rtreflink > being merged. That's all in for-next now, though I don't think there's going to be a xfsprogs release until the kernel does it. --D
diff --git a/common/xfs b/common/xfs index 93260fdb4599..807454d3e03b 100644 --- a/common/xfs +++ b/common/xfs @@ -160,6 +160,11 @@ _try_scratch_mkfs_xfs() grep -q crc=0 $tmp.mkfsstd && _force_xfsv4_mount_options + grep -q "zoned file systems do not support" $tmp.mkfserr && \ + _notrun "Not supported on zoned file systems" + grep -q "must be greater than the minimum" $tmp.mkfserr && \ + _notrun "Zone count too small" + if [ $mkfs_status -eq 0 -a "$LARGE_SCRATCH_DEV" = yes ]; then # manually parse the mkfs output to get the fs size in bytes local fs_size
Check for a few errors issued for unsupported zoned configurations in _try_scratch_mkfs_xfs so that the test is not run instead of failed. Signed-off-by: Christoph Hellwig <hch@lst.de> --- common/xfs | 5 +++++ 1 file changed, 5 insertions(+)