| Message ID | 20250409075557.3535745-34-hch@lst.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [01/45] xfs: generalize the freespace and reserved blocks handling | expand |
On Wed, Apr 09, 2025 at 09:55:36AM +0200, Christoph Hellwig wrote: > Until GC is enhanced to not unshared reflinked blocks we better prohibit > this combination. > > Signed-off-by: Christoph Hellwig <hch@lst.de> ...or gc figures out how to do reflinked moves. Either way, Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> --D > --- > mkfs/xfs_mkfs.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c > index 7d4114e8a2ea..0e351f9efc32 100644 > --- a/mkfs/xfs_mkfs.c > +++ b/mkfs/xfs_mkfs.c > @@ -2957,6 +2957,14 @@ _("rt extent size not supported on realtime devices with zoned mode\n")); > } > cli->rtextsize = 0; > } > + if (cli->sb_feat.reflink) { > + if (cli_opt_set(&mopts, M_REFLINK)) { > + fprintf(stderr, > +_("reflink not supported on realtime devices with zoned mode specified\n")); > + usage(); > + } > + cli->sb_feat.reflink = false; > + } > > /* > * Force the rtinherit flag on the root inode for zoned file > -- > 2.47.2 > >
On Wed, Apr 09, 2025 at 12:00:00PM -0700, Darrick J. Wong wrote: > On Wed, Apr 09, 2025 at 09:55:36AM +0200, Christoph Hellwig wrote: > > Until GC is enhanced to not unshared reflinked blocks we better prohibit > > this combination. > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > ...or gc figures out how to do reflinked moves. Either way, That's what I mean with not unsharing. I can adjust the wording if mine was too confusing, though.
On Thu, Apr 10, 2025 at 08:46:31AM +0200, Christoph Hellwig wrote: > On Wed, Apr 09, 2025 at 12:00:00PM -0700, Darrick J. Wong wrote: > > On Wed, Apr 09, 2025 at 09:55:36AM +0200, Christoph Hellwig wrote: > > > Until GC is enhanced to not unshared reflinked blocks we better prohibit > > > this combination. > > > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > > > ...or gc figures out how to do reflinked moves. Either way, > > That's what I mean with not unsharing. I can adjust the wording > if mine was too confusing, though. "Don't allow reflink until zonegc learns how to deal with shared extents." ? --D
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c index 7d4114e8a2ea..0e351f9efc32 100644 --- a/mkfs/xfs_mkfs.c +++ b/mkfs/xfs_mkfs.c @@ -2957,6 +2957,14 @@ _("rt extent size not supported on realtime devices with zoned mode\n")); } cli->rtextsize = 0; } + if (cli->sb_feat.reflink) { + if (cli_opt_set(&mopts, M_REFLINK)) { + fprintf(stderr, +_("reflink not supported on realtime devices with zoned mode specified\n")); + usage(); + } + cli->sb_feat.reflink = false; + } /* * Force the rtinherit flag on the root inode for zoned file
Until GC is enhanced to not unshared reflinked blocks we better prohibit this combination. Signed-off-by: Christoph Hellwig <hch@lst.de> --- mkfs/xfs_mkfs.c | 8 ++++++++ 1 file changed, 8 insertions(+)