| Message ID | 20250409075557.3535745-36-hch@lst.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [01/45] xfs: generalize the freespace and reserved blocks handling | expand |
On Wed, Apr 09, 2025 at 09:55:38AM +0200, Christoph Hellwig wrote: > Also fix up to report all the zoned information in a separate line, > which also helps with alignment. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Could all these xfs_report_geom should be a single patch? Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> --D > --- > libfrog/fsgeom.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libfrog/fsgeom.c b/libfrog/fsgeom.c > index 5c4ba29ca9ac..b4107b133861 100644 > --- a/libfrog/fsgeom.c > +++ b/libfrog/fsgeom.c > @@ -70,7 +70,8 @@ xfs_report_geom( > "log =%-22s bsize=%-6d blocks=%u, version=%d\n" > " =%-22s sectsz=%-5u sunit=%d blks, lazy-count=%d\n" > "realtime =%-22s extsz=%-6d blocks=%lld, rtextents=%lld\n" > -" =%-22s rgcount=%-4d rgsize=%u extents, zoned=%d\n"), > +" =%-22s rgcount=%-4d rgsize=%u extents\n" > +" =%-22s zoned=%-6d start=%llu reserved=%llu\n"), > mntpoint, geo->inodesize, geo->agcount, geo->agblocks, > "", geo->sectsize, attrversion, projid32bit, > "", crcs_enabled, finobt_enabled, spinodes, rmapbt_enabled, > @@ -86,7 +87,8 @@ xfs_report_geom( > !geo->rtblocks ? _("none") : rtname ? rtname : _("internal"), > geo->rtextsize * geo->blocksize, (unsigned long long)geo->rtblocks, > (unsigned long long)geo->rtextents, > - "", geo->rgcount, geo->rgextents, zoned); > + "", geo->rgcount, geo->rgextents, > + "", zoned, geo->rtstart, geo->rtreserved); > } > > /* Try to obtain the xfs geometry. On error returns a negative error code. */ > -- > 2.47.2 > >
On Wed, Apr 09, 2025 at 12:01:44PM -0700, Darrick J. Wong wrote: > On Wed, Apr 09, 2025 at 09:55:38AM +0200, Christoph Hellwig wrote: > > Also fix up to report all the zoned information in a separate line, > > which also helps with alignment. > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > Could all these xfs_report_geom should be a single patch? Yes, that works much better. > Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> Although between all the changes I won't add the Reviewed-by tag for now.
diff --git a/libfrog/fsgeom.c b/libfrog/fsgeom.c index 5c4ba29ca9ac..b4107b133861 100644 --- a/libfrog/fsgeom.c +++ b/libfrog/fsgeom.c @@ -70,7 +70,8 @@ xfs_report_geom( "log =%-22s bsize=%-6d blocks=%u, version=%d\n" " =%-22s sectsz=%-5u sunit=%d blks, lazy-count=%d\n" "realtime =%-22s extsz=%-6d blocks=%lld, rtextents=%lld\n" -" =%-22s rgcount=%-4d rgsize=%u extents, zoned=%d\n"), +" =%-22s rgcount=%-4d rgsize=%u extents\n" +" =%-22s zoned=%-6d start=%llu reserved=%llu\n"), mntpoint, geo->inodesize, geo->agcount, geo->agblocks, "", geo->sectsize, attrversion, projid32bit, "", crcs_enabled, finobt_enabled, spinodes, rmapbt_enabled, @@ -86,7 +87,8 @@ xfs_report_geom( !geo->rtblocks ? _("none") : rtname ? rtname : _("internal"), geo->rtextsize * geo->blocksize, (unsigned long long)geo->rtblocks, (unsigned long long)geo->rtextents, - "", geo->rgcount, geo->rgextents, zoned); + "", geo->rgcount, geo->rgextents, + "", zoned, geo->rtstart, geo->rtreserved); } /* Try to obtain the xfs geometry. On error returns a negative error code. */
Also fix up to report all the zoned information in a separate line, which also helps with alignment. Signed-off-by: Christoph Hellwig <hch@lst.de> --- libfrog/fsgeom.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)